Last modified: 2014-07-23 00:50:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T69377, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 67377 - VisualEditor: Converting a numbered external link to a regular one from the link inspector drops the annotations
VisualEditor: Converting a numbered external link to a regular one from the l...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Data Model (Other open bugs)
unspecified
All All
: Normal normal
: VE-deploy-2014-07-24
Assigned To: Bartosz Dziewoński
:
Depends on:
Blocks: ve-linkediting 51309
  Show dependency tree / graph
 
Reported: 2014-07-01 17:49 UTC by Bartosz Dziewoński
Modified: 2014-07-23 00:50 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Bartosz Dziewoński 2014-07-01 17:49:22 UTC 
Converting a MWNumberedExternalLinkNode to MWExternalLinkAnnotation from the UI (link inspector) loses annotations on the node, even though there is code in place that aims handle this.

See the behavior of the 'convert' variable in ve.ui.MWLinkNodeInspector.prototype.getTeardownProcess.
Comment 1 Bartosz Dziewoński 2014-07-01 19:28:08 UTC 
This is because the node is removed from DM before its annotations are copied. Let me just fix it while I'm at it. :)
Comment 2 Gerrit Notification Bot 2014-07-01 19:47:33 UTC 
Change 143387 had a related patch set uploaded by Bartosz Dziewoński:
MWLinkNodeInspector: Actually preserve annotations when converting to link annotation

https://gerrit.wikimedia.org/r/143387
Comment 3 Gerrit Notification Bot 2014-07-23 00:44:46 UTC 
Change 143387 merged by jenkins-bot:
MWLinkNodeInspector: Actually preserve annotations when converting to link annotation

https://gerrit.wikimedia.org/r/143387
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links