Last modified: 2014-08-20 21:29:13 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T69330, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 67330 - VisualEditor: On a redirected page, VE URL retains original searched title instead of redirect title


Summary:	VisualEditor: On a redirected page, VE URL retains original searched title in...

Status:	RESOLVED WORKSFORME

Product:	VisualEditor
Classification:	Unclassified
Component:	MediaWiki integration (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal minor
Target Milestone:	---
Assigned To:	Bartosz Dziewoński

URL:
Whiteboard:
Keywords:

Depends on:	35045
Blocks:
	Show dependency tree / graph

Reported:	2014-06-30 21:24 UTC by Kaity Hammerstein
Modified:	2014-08-20 21:29 UTC (History)
CC List:	3 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Kaity Hammerstein 2014-06-30 21:24:47 UTC

If I go to a page that has been redirected, the URL retains the original title instead of the redirected title. So if I enter VE and then refresh, I'm taken to the editing the original page instead of the redirect page.

For example, go here: https://en.wikipedia.org/wiki/Zedonk, then click VE, then refresh the page. 

URL should be changed to: https://en.wikipedia.org/wiki/Zebroid?veaction=edit

Comment 1 James Forrester 2014-06-30 21:30:27 UTC

Rewriting the URL is a bit evil, but if we don't we have the issue of users having a URL they can't share/reload without the context changing.

Ideally MediaWiki's redirects should 307 rather than 200 so we don't have this problem… :-(

Comment 2 Bartosz Dziewoński 2014-06-30 21:31:57 UTC

(In reply to James Forrester from comment #1)
> Ideally MediaWiki's redirects should 307 rather than 200 so we don't have
> this problem… :-(

They shouldn't because then you can't show the "Redirected from" message without hacks, but they probably should update the URL with JavaScript instead. Wanna file a bug or that? (I wouldn't be surprised if there was one already.)

Comment 3 James Forrester 2014-06-30 21:35:18 UTC

(In reply to Bartosz Dziewoński from comment #2)
> (In reply to James Forrester from comment #1)
> > Ideally MediaWiki's redirects should 307 rather than 200 so we don't have
> > this problem… :-(
> 
> They shouldn't because then you can't show the "Redirected from" message
> without hacks,

I'm aware of that minor impact on users, but that info is normally duplicated by editorial templates anyway on Wikimedia wikis, at least.

> but they probably should update the URL with JavaScript instead.

> Wanna file a bug or that? (I wouldn't be surprised if there was one already.)

Yes, that looks like bug 35045.

Comment 4 Kaity Hammerstein 2014-06-30 22:05:03 UTC

Note: This doesn't happen on mobile, on refresh user stays on redirect page.

Comment 5 Gerrit Notification Bot 2014-07-03 10:29:50 UTC

Change 143852 had a related patch set uploaded by Bartosz Dziewoński:
On redirect, actually rewrite page URL to the target one with JavaScript

https://gerrit.wikimedia.org/r/143852

Comment 6 James Forrester 2014-07-03 15:37:05 UTC

Likely to be made WORKSFORME by Gerrit change #143852 but isn't actually a patch for VE. :-)

Comment 7 Bartosz Dziewoński 2014-08-20 21:29:13 UTC

That change has been merged and this should therefore be magically fixed. I'd appreciate if someone could verify.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links