Last modified: 2014-09-27 01:44:09 UTC
VisualEditor correctly introduces visualeditor-ca-editsource, visualeditor-ca-editsource-section to change meaning of action=edit links, but it seems to reuse messages such as editsection, monobook-view-edit, vector-view-edit for its own veaction=edit links. https://www.mediawiki.org/wiki/Localisation#Avoid_message_reuse
monobook-view-create and vector-view-create are also reused. As written in VisualEditor.php, we can avoid message reuse by adding the following code: $wgVisualEditorTabMessages['edit'] = 'visualeditor-ca-ve-edit'; $wgVisualEditorTabMessages['create'] = 'visualeditor-ca-ve-create'; $wgVisualEditorTabMessages['editsection'] = 'visualeditor-ca-ve-edit-section'; But visualeditor-ca-ve-edit, visualeditor-ca-ve-create, and visualeditor-ca-ve-edit-section are all "VisualEditor".
I don't see why we would need separate messages for these. As far as I can see, they are used on the same location for the same function, so having separate messages would be unnecessary duplication imho. Message re-use needs to be avoided when re-using them in a different context.
(In reply to Robin Pepermans (SPQRobin) from comment #2) > Message re-use > needs to be avoided when re-using them in a different context. How is linking veaction=edit not a different context than action=edit?
(In reply to Nemo from comment #3) > How is linking veaction=edit not a different context than action=edit? They are on the same location and for the same function (i.e. editing). There is only a slight difference, i.e. in core it uses the normal editor while in VisualEditor obviously the visual editor. In my opinion, this does not weigh against having yet another message and consequently having only few translations. Which makes me think, maybe we should have the ability to fall back to another message if a certain (identical but more specific) message is not translated.
Change 147737 had a related patch set uploaded by Nemo bis: Don't steal core's 'edit', 'create', 'editsection' by default https://gerrit.wikimedia.org/r/147737
(In reply to Robin Pepermans (SPQRobin) from comment #4) > having yet another message and consequently having only > few translations. No such risk in my proposal.
Change 147737 abandoned by Jforrester: Don't steal core's 'edit', 'create', 'editsection' by default Reason: Per discussion. https://gerrit.wikimedia.org/r/147737
