Last modified: 2014-09-27 01:44:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 67274 - Core message reuse
Core message reuse
Status: RESOLVED WONTFIX
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Editing team bugs – take if you're interested!
: i18n
Depends on:
Blocks: messages
  Show dependency treegraph
 
Reported: 2014-06-29 12:34 UTC by Nemo
Modified: 2014-09-27 01:44 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Nemo 2014-06-29 12:34:59 UTC
VisualEditor correctly introduces visualeditor-ca-editsource, visualeditor-ca-editsource-section to change meaning of action=edit links, but it seems to reuse messages such as editsection, monobook-view-edit, vector-view-edit for its own veaction=edit links.
https://www.mediawiki.org/wiki/Localisation#Avoid_message_reuse
Comment 1 Yuki Shira 2014-06-29 14:45:14 UTC
monobook-view-create and vector-view-create are also reused.

As written in VisualEditor.php, we can avoid message reuse by adding the following code:
 $wgVisualEditorTabMessages['edit'] = 'visualeditor-ca-ve-edit';
 $wgVisualEditorTabMessages['create'] = 'visualeditor-ca-ve-create';
 $wgVisualEditorTabMessages['editsection'] = 'visualeditor-ca-ve-edit-section';

But visualeditor-ca-ve-edit, visualeditor-ca-ve-create, and visualeditor-ca-ve-edit-section are all "VisualEditor".
Comment 2 Robin Pepermans (SPQRobin) 2014-06-30 16:19:54 UTC
I don't see why we would need separate messages for these. As far as I can see, they are used on the same location for the same function, so having separate messages would be unnecessary duplication imho. Message re-use needs to be avoided when re-using them in a different context.
Comment 3 Nemo 2014-06-30 16:29:53 UTC
(In reply to Robin Pepermans (SPQRobin) from comment #2)
> Message re-use
> needs to be avoided when re-using them in a different context.

How is linking veaction=edit not a different context than action=edit?
Comment 4 Robin Pepermans (SPQRobin) 2014-06-30 18:13:41 UTC
(In reply to Nemo from comment #3)
> How is linking veaction=edit not a different context than action=edit?

They are on the same location and for the same function (i.e. editing). There is only a slight difference, i.e. in core it uses the normal editor while in VisualEditor obviously the visual editor. In my opinion, this does not weigh against having yet another message and consequently having only few translations. 

Which makes me think, maybe we should have the ability to fall back to another message if a certain (identical but more specific) message is not translated.
Comment 5 Gerrit Notification Bot 2014-07-19 13:59:11 UTC
Change 147737 had a related patch set uploaded by Nemo bis:
Don't steal core's 'edit', 'create', 'editsection' by default

https://gerrit.wikimedia.org/r/147737
Comment 6 Nemo 2014-07-19 14:10:38 UTC
(In reply to Robin Pepermans (SPQRobin) from comment #4)
> having yet another message and consequently having only
> few translations.

No such risk in my proposal.
Comment 7 Gerrit Notification Bot 2014-08-25 18:19:25 UTC
Change 147737 abandoned by Jforrester:
Don't steal core's 'edit', 'create', 'editsection' by default

Reason:
Per discussion.

https://gerrit.wikimedia.org/r/147737

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links