Last modified: 2014-11-17 00:37:00 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T69238, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 67238 - Factor diff logic out of EntityContent
Factor diff logic out of EntityContent
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Wikidata bugs
u=dev c=backend p=0
:
Depends on:
Blocks: 69752
  Show dependency treegraph
 
Reported: 2014-06-28 07:42 UTC by Daniel Kinzler
Modified: 2014-11-17 00:37 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Daniel Kinzler 2014-06-28 07:42:22 UTC
EntityContent currently implements the part of the diffing logic that handles redirects. This should be factored out into an EntityContentDiffer. Plus maybe an EntityContentPatcher, though I think patching can and perhaps should be handled by the differ, too - that would keep the knowledge about the data structures used for diffing in a single class.
Comment 1 Gordon P. Hemsley 2014-11-17 00:37:00 UTC
How does this relate to EntityContentDiff, EntityContentDiffView, EntityDiffVisualizer, and other classes?

And, if this isn't what EntityContentDiff does, where should this code live?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links