Last modified: 2014-06-24 20:48:38 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68929, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 66929 - Fatal error: Class already declared: OAuthException


Summary:	Fatal error: Class already declared: OAuthException

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	OAuth (Other open bugs)
Version:	master
Hardware:	All All

Importance:	Highest normal (vote)
Target Milestone:	---
Assigned To:	Chris Steipp

URL:
Whiteboard:
Keywords:	hhvm

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-06-22 01:21 UTC by Ori Livneh
Modified:	2014-06-24 20:48 UTC (History)
CC List:	5 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Ori Livneh 2014-06-22 01:21:36 UTC

HHVM bundles a port of the OAuth PECL extension by default, and it defines an OAuthException class. Attempting to load Extension:OAuth under HHVM causes a "Class already declared" fatal to be thrown.

Comment 1 Chris Steipp 2014-06-23 19:23:04 UTC

Since the PECL extension just extends the default exception with two extra properties (if I understand the code right), which is compatible with the library we're using, I think we can just conditionally define the exception, and everything will work.

Changing the name would be fine, except we already have an MWOAuthException, which has a slightly different usage, and I'd rather not have to refactor those.

Comment 2 Gerrit Notification Bot 2014-06-23 19:32:25 UTC

Change 141496 had a related patch set uploaded by CSteipp:
Play nice with PECL

https://gerrit.wikimedia.org/r/141496

Comment 3 Gerrit Notification Bot 2014-06-24 00:23:46 UTC

Change 141608 had a related patch set uploaded by CSteipp:
Add MWOAuth namespace

https://gerrit.wikimedia.org/r/141608

Comment 4 Gerrit Notification Bot 2014-06-24 17:02:26 UTC

Change 141496 abandoned by CSteipp:
Play nice with PECL

https://gerrit.wikimedia.org/r/141496

Comment 5 Gerrit Notification Bot 2014-06-24 20:00:54 UTC

Change 141608 merged by Ori.livneh:
Add MediaWiki\Extensions\OAuth namespace

https://gerrit.wikimedia.org/r/141608

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links