Last modified: 2014-08-13 11:23:03 UTC
All 3 are currently deployed and really should have jobs.
Beside the usual jslint/phplint jobs, I am wondering whether we should run qunit jobs with the skin set. Though I think we only ran the qunit job against the default skin.
The tutorial for MediaWiki extensions should be more or less valid for skins : https://www.mediawiki.org/wiki/Continuous_integration/Tutorials/Adding_a_MediaWiki_extension I have no clue what should be tested so this is on hold until someone figure out the testing strategy to be applied on mediawiki/skins/*
(In reply to Antoine "hashar" Musso from comment #2) > I have no clue what should be tested so this is on hold until someone figure > out the testing strategy to be applied on mediawiki/skins/* For now just basic lint checks, so php -l, jslint, and I believe we have a test that checks for validity of .less files?
Yeah. There's no reason why a skin couldn't have unit tests or browser tests, but as far as I know none does right now.
Maybe we can run the qunit tests as well? Not sure whether they are passing though.
They should be, but some code (too tightly integrated with page HTML, like mw.util.addPortletLink) is known not to work with all skins. Not sure if the tests for this and other things will work correctly, but it would be nice to try.
(Example skin too, please: https://git.wikimedia.org/tree/mediawiki%2Fskins%2FExample.git)
Change 148130 had a related patch set uploaded by Hashar: php lint jobs for MediaWiki skins https://gerrit.wikimedia.org/r/148130
Change 148136 had a related patch set uploaded by Hashar: phplint jobs for MediaWiki skins https://gerrit.wikimedia.org/r/148136
Change 148136 merged by jenkins-bot: phplint jobs for MediaWiki skins https://gerrit.wikimedia.org/r/148136
Change 148130 merged by jenkins-bot: phplint jobs for MediaWiki skins https://gerrit.wikimedia.org/r/148130
I have configured Jenkins and Zuul to trigger a phplint job. The configuration and tests jobs are sharing the same Change-Id: I3ced08099f7283f75f61c170c291f7a80ee79a5b We still want to add: - jshint jobs, the skins will have to pass it - run the MediaWiki tests that do some generic checks such as ensuring resource loader modules are properly registered Ideally qunit tests :-)
mediawiki/skins/Vector also needs jobs.
Change 153578 had a related patch set uploaded by Addshore: Add phplint jobs for 2 skins that were missed https://gerrit.wikimedia.org/r/153578
Change 153579 had a related patch set uploaded by Addshore: Add 2 zuul triggers for skins missing them https://gerrit.wikimedia.org/r/153579
Change 153578 merged by jenkins-bot: Add jobs for 2 skins that were missing https://gerrit.wikimedia.org/r/153578
Change 153579 merged by jenkins-bot: Add 2 zuul triggers for skins missing them https://gerrit.wikimedia.org/r/153579
Thanks guys. Can/Should this be closed now? It seems that all skin repos that have something worth testing in them are now being tested. I suggest tracking more interesting things like QUnit jobs in separate bug(s).
The skins must now have a bunch of MediaWiki core tests run on them, just like extensions. Ie the tests under /tests/phpunit/structure/ (which are the PHPUnit 'structure' test suite) and /tests/phpunit/LessTestSuite.php.
