Last modified: 2014-11-11 02:35:43 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68860, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 66860 - Cite: If there's no <references /> block on the page, show one automatically below the content rather than showing an error
Cite: If there's no <references /> block on the page, show one automatically ...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Cite (Other open bugs)
master
All All
: Normal enhancement (vote)
: ---
Assigned To: Alex Monk
:
Depends on:
Blocks: 67845
  Show dependency treegraph
 
Reported: 2014-06-19 22:41 UTC by James Forrester
Modified: 2014-11-11 02:35 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description James Forrester 2014-06-19 22:41:59 UTC
From bug 54906 comment 16:

> Why not treat references like the TOC and always have MediaWiki output
> them at the bottom of the page (or section when in preview mode in
> wikitext) unless a <references/> tag is present?

This would treat newbies slightly better with a first-approximation of a non-failure state, which means fewer nasty errors.
Comment 1 James Forrester 2014-06-23 18:07:14 UTC
Bug 29774 might possibly be tangentially/accidentally fixed by this, but it's not a blocker; that's complaining about the parser order of the page.
Comment 2 Gerrit Notification Bot 2014-06-23 21:45:37 UTC
Change 141583 had a related patch set uploaded by Alex Monk:
If there's no main <references /> block on the page, show one automatically below the content

https://gerrit.wikimedia.org/r/141583
Comment 3 Gerrit Notification Bot 2014-06-30 22:11:14 UTC
Change 141583 merged by jenkins-bot:
If there's no main <references /> block on the page, show one automatically below the content

https://gerrit.wikimedia.org/r/141583
Comment 4 Thiemo Mättig 2014-07-01 07:49:35 UTC
We (WMDE) had this on our radar too and came to the same conclusion. So thank you!

https://de.wikipedia.org/wiki/Wikipedia:Umfragen/Technische_W%C3%BCnsche/Top_20/Wunsch_1

Possible follow-ups:

1. Add a <div> around the automatically appended references so users can style them either in their personal CSS or the project's Common.css.

2. Add a possibility to auto-categorize these cases so users can find them.
Comment 5 Jared Zimmerman (WMF) 2014-07-01 08:12:57 UTC
@kaity had some ideas and designs around auto formatting and grouping that might be applicable.
Comment 6 Jared Zimmerman (WMF) 2014-07-03 16:17:58 UTC
Has this been integrated? I tried to simulate it by removing an existing {{reflist}} and saving a page but still received an error.

I thought the goal was to mimic the TOC behavior?
Comment 7 James Forrester 2014-07-03 16:22:08 UTC
(In reply to Jared Zimmerman (WMF) from comment #6)
> Has this been integrated? I tried to simulate it by removing an existing
> {{reflist}} and saving a page but still received an error.
> 
> I thought the goal was to mimic the TOC behavior?

Per https://gerrit.wikimedia.org/r/#/c/141583/ it's not been deployed yet.
Comment 8 Jared Zimmerman (WMF) 2014-07-03 17:14:27 UTC
@james, thank you.
Comment 9 Gadget850 2014-07-07 09:58:02 UTC
There are a few issues with the automatic addition of the reference list:
* Follow-on editors are going to be confused since the markup is missing
* There is no heading
* The reference list will often show in the wrong place

I propose that 'MediaWiki:Cite error refs without references' still be triggered. The default message would not show an error but would put the page into a hidden maintenance category.
Comment 10 Jared Zimmerman (WMF) 2014-07-07 18:52:19 UTC
@Gadget850, I'll reiterate, that yes, those cases are less than ideal, but having a missing reflist, or showing the big red error on articles seems to far outweigh them. The missing heading will be a good clue for more advanced editors to come back and clean things up for helpful, well intentioned new editors who are having troubles navigating the complexities of wiki editing. 

I think the hidden maintenance category could be a good addition, but i don't see it as a blocker for integrating this.
Comment 11 James Forrester 2014-07-07 18:59:42 UTC
(In reply to Gadget850 from comment #9)
> There are a few issues with the automatic addition of the reference list:
> * Follow-on editors are going to be confused since the markup is missing

I'm sure they will learn soon enough. This is how the __TOC__ flag works, and intentionally mirrors it.


> * There is no heading

The desired heading, level and other context varies per wiki, so the software can't know what to put in unless we do some horrible hack.


> * The reference list will often show in the wrong place

This is also a matter of wikis' individual tastes, but yes, for some wikis the absolute bottom of the page is not how they currently want these to show up.


> I propose that 'MediaWiki:Cite error refs without references' still be
> triggered. The default message would not show an error but would put the
> page into a hidden maintenance category.

Interesting idea. Given the vast change in semantics, presumably this should be a new message (and the old one deleted)?
Comment 12 Gadget850 2014-07-07 20:45:06 UTC
(In reply to James Forrester from comment #11)
> (In reply to Gadget850 from comment #9)
> > * There is no heading
> 
> The desired heading, level and other context varies per wiki, so the
> software can't know what to put in unless we do some horrible hack.

Exactly my point. The maintenance category would allow maintenance editors to find and fix the issue, just as they currently do.

> > * The reference list will often show in the wrong place
> 
> This is also a matter of wikis' individual tastes, but yes, for some wikis
> the absolute bottom of the page is not how they currently want these to show
> up.

Again, the maintenance category would allow maintenance editors to find and fix the issue.

> > I propose that 'MediaWiki:Cite error refs without references' still be
> > triggered. The default message would not show an error but would put the
> > page into a hidden maintenance category.
> 
> Interesting idea. Given the vast change in semantics, presumably this should
> be a new message (and the old one deleted)?

The name is not a big issue. But 'MediaWiki:Cite error refs without references' would be obsolete when this is deployed and should be removed if not reused.
Comment 13 James Forrester 2014-07-07 21:10:30 UTC
(In reply to Gadget850 from comment #12)
> (In reply to James Forrester from comment #11)
> > (In reply to Gadget850 from comment #9)
> > > I propose that 'MediaWiki:Cite error refs without references' still be
> > > triggered. The default message would not show an error but would put the
> > > page into a hidden maintenance category.
> > 
> > Interesting idea. Given the vast change in semantics, presumably this should
> > be a new message (and the old one deleted)?
> 
> The name is not a big issue. But 'MediaWiki:Cite error refs without
> references' would be obsolete when this is deployed and should be removed if
> not reused.

Yes. Maybe we should just prompt for the name of a category, and if set, categorise them; otherwise they would be uncategorised?
Comment 14 Gadget850 2014-07-08 10:18:23 UTC
So- reopen this bug or open a new one?
Comment 15 James Forrester 2014-07-08 15:18:35 UTC
(In reply to Gadget850 from comment #14)
> So- reopen this bug or open a new one?

A new one would be appropriate. This bug is complete.
Comment 16 Gadget850 2014-07-08 23:22:37 UTC
Bug 67700
Comment 17 Gadget850 2014-07-10 22:40:45 UTC
Now deployed. The automatic reference list is generated when {{reflist}} or <references /> is missing.

The automatic reference list is not generated when there is a group; 'MediaWiki:Cite error group refs without references' is still triggered and an error shows.
Comment 18 Alex Monk 2014-07-10 23:52:41 UTC
(In reply to Gadget850 from comment #17)
> The automatic reference list is not generated when there is a group;
> 'MediaWiki:Cite error group refs without references' is still triggered and
> an error shows.

Yeah, I'm not sure what you would expect it to do there.
Comment 19 Gadget850 2014-07-11 10:43:22 UTC
New problem: Bug 67845
Comment 20 Gadget850 2014-07-20 11:55:43 UTC
Bug 68293 - Cite: Indent before automatic reference list displays list style as unordered
Comment 21 Matthias Becker 2014-07-21 09:22:55 UTC
Reiterating the proposal to keep maintenance category because normally the references tag should not apppear at the end of the page. As all editors know the end of the page have to be the categories and in some Wikipedia language versions metadata like [[:de:Vorlage:Personendaten]] or [[:en:Template:Person data]]; therefor the missing tag still states to be an issue to be kept with, even if the reader does not get aware of it.
Comment 22 Thiemo Mättig 2014-07-21 09:28:37 UTC
(In reply to Matthias Becker from comment #21)
> Reiterating the proposal to keep maintenance category

Did you missed bug 67700?
Comment 23 Gadget850 2014-07-21 15:05:02 UTC
Bug 68324 - Cite: Add namespace detection for automatically generated reference list

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links