Last modified: 2014-06-19 02:36:20 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68804, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 66804 - OOjs: Support ES3
OOjs: Support ES3
Status: RESOLVED FIXED
Product: OOjs
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: High enhancement
: ---
Assigned To: Krinkle
:
Depends on: 56341 63303
Blocks:
  Show dependency treegraph
 
Reported: 2014-06-18 18:03 UTC by Krinkle
Modified: 2014-06-19 02:36 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Krinkle 2014-06-18 18:03:28 UTC
After bug 63303 and 56341 are fixed, we're not done yet.

I just ran a bunch of tests and IE8 is breaking all over the place due to various bugs and lackings in its javascript engine. Nothing major, but will need to be handled.


One of those random little things is the lack of self-identifier reference.

e.g.

> oo.method = function (something) {
>     function foo() {
>         ..
>         something(foo);
>         ..
>     }
>     return foo(); 
> };

We use this in EventEmitter#off. I'm working on a commit now to fix all the test failures.
Comment 1 Gerrit Notification Bot 2014-06-18 18:51:08 UTC
Change 140436 had a related patch set uploaded by Krinkle:
Implement support for ES3 browsers (tests passing in IE8!)

https://gerrit.wikimedia.org/r/140436
Comment 2 Gerrit Notification Bot 2014-06-19 02:29:28 UTC
Change 140436 merged by jenkins-bot:
Implement support for ES3 browsers (tests passing in IE6-8!)

https://gerrit.wikimedia.org/r/140436

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links