Last modified: 2014-06-16 15:18:22 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68647, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 66647 - data-sort-type should correlate the currencies of data-sort-value cells with 'currency criterion' compatible cells when used sparcely
data-sort-type should correlate the currencies of data-sort-value cells with ...
Status: UNCONFIRMED
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
1.24rc
All All
: Lowest enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 31601
  Show dependency treegraph
 
Reported: 2014-06-16 02:05 UTC by Matthew Millar
Modified: 2014-06-16 15:18 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Matthew Millar 2014-06-16 02:05:15 UTC
When sorting a column which contains currency values:
Cells with both 'currency criterion' incompatible values and data-sort-value specified with a 'currency criterion' compatible symbol are not included in the comparative ordering of 'currency criterion' compatible values.

E.g.
{| class="wikitable sortable"
|+ Comparison of keyboards, segmented by purpose
|-
! Manufacturer !! class="unsortable" | Model !! data-sort-type="currency" | Price
|-
! class="collapsible collapsed" colspan=12 | Wireless
|-
| Amkette || Wi-Key Touch || data-sort-value="$42" | INR₹2495 ($42)
|-
| Rapoo || E2700 || £39.99 ($68)
|-
| iball || Mystic BT06 || data-sort-value="$33" | INR₹1,999 ($33)
|-
|}

What happens when Price column is sorted:
{| class="wikitable sortable"
|+ Comparison of keyboards, segmented by purpose
|-
! Manufacturer !! class="unsortable" | Model !! data-sort-type="currency" | Price
|-
! class="collapsible collapsed" colspan=12 | Wireless
|-
| iball || Mystic BT06 || data-sort-value="$33" | INR₹1,999 ($33)
|-
| Rapoo || E2700 || £39.99 ($68)
|-
| Amkette || Wi-Key Touch || data-sort-value="$42" | INR₹2495 ($42)
|-
|}

What should happen:
==Keyboards==
{| class="wikitable sortable"
|+ Comparison of keyboards, segmented by purpose
|-
! Manufacturer !! class="unsortable" | Model !! data-sort-type="currency" | Price
|-
! class="collapsible collapsed" colspan=12 | Wireless
|-
| iball || Mystic BT06 || data-sort-value="$33" | INR₹1,999 ($33)
|-
| Amkette || Wi-Key Touch || data-sort-value="$42" | INR₹2495 ($42)
|-
| Rapoo || E2700 || £39.99 ($68)
|-
|}
Comment 1 Andre Klapper 2014-06-16 09:34:28 UTC
Workaround: Put first what's currently in the brackets.
Comment 2 Matthew Millar 2014-06-16 10:46:18 UTC
To maintain the difference between backend functionality and UX, use of data-sort-value on each cell of the column with a standardized currency is a workaround.
Comment 3 Derk-Jan Hartman 2014-06-16 11:17:07 UTC
I don't see why it would do that. 'garbage in, garbage out' principle of keeping data applies here in my opinion. If you leave the program guessing, it is undoubtedly going to guess wrong in certain cases.

Using data-sort-value consistently is what I think is the appropriate approach here.
Comment 4 Bartosz Dziewoński 2014-06-16 14:07:17 UTC
Yeah, I agree.
Comment 5 Andre Klapper 2014-06-16 15:18:22 UTC
Sounds like WONTFIX to me.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links