Last modified: 2014-06-09 20:09:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68292, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 66292 - jquery.cycle.all.js uses jQuery.browser


Summary:	jquery.cycle.all.js uses jQuery.browser

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	JavaScript (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Unprioritized normal (vote)
Target Milestone:	---
Assigned To:	Krinkle

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	jqmigrate-$.browser
	Show dependency tree / graph

Reported:	2014-06-06 23:32 UTC by Matthew Flaschen
Modified:	2014-06-09 20:09 UTC (History)
CC List:	4 users (show)

See Also:	66391
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Matthew Flaschen 2014-06-06 23:32:31 UTC

jQuery cycle (https://git.wikimedia.org/blob/mediawiki%2Fcore.git/9c51f78a12e9817da0593631c1c3426abb574915/resources%2Flib%2Fjquery%2Fjquery.cycle.all.js) uses jQuery browser, which will be removed when jQuery Migrate is.

However, there is a new version that does not.

Comment 1 Gerrit Notification Bot 2014-06-06 23:49:19 UTC

Change 138108 had a related patch set uploaded by Mattflaschen:
Upgrade jQuery Cycle; new version does not use $.browser

https://gerrit.wikimedia.org/r/138108

Comment 2 Matthew Flaschen 2014-06-06 23:52:03 UTC

This is not used in core, or even modularized for RL, so I'm not sure we should keep it.  See Gerrit.

Comment 3 paladox2015 2014-06-07 13:20:28 UTC

Hi I uploaded an update to that file here https://gerrit.wikimedia.org/r/#/c/138165/

Comment 4 Andre Klapper 2014-06-07 17:07:01 UTC

paladox2015: Also see [[mw:Gerrit/Commit_message_guidelines]]

Comment 5 Gerrit Notification Bot 2014-06-09 20:04:13 UTC

Change 138108 merged by jenkins-bot:
Remove unused jquery.cycle.all.js file

https://gerrit.wikimedia.org/r/138108

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links