Last modified: 2014-10-16 19:22:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68206, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 66206 - VisualEditor: Replace uses of push.apply with something safe
VisualEditor: Replace uses of push.apply with something safe
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Technical Debt (Other open bugs)
unspecified
All All
: Normal enhancement
: VE-deploy-2014-10-23 (1.25wmf5)
Assigned To: Sucheta Ghoshal
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-06-05 18:31 UTC by Roan Kattouw
Modified: 2014-10-16 19:22 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Roan Kattouw 2014-06-05 18:31:39 UTC 
Similar to how we have ve.batchSplice for splice.apply
Comment 1 Gerrit Notification Bot 2014-10-15 18:47:42 UTC 
Change 166790 had a related patch set uploaded by SuchetaG:
Replacing push.apply with newly created ve.batchPush in VE core

https://gerrit.wikimedia.org/r/166790
Comment 2 Gerrit Notification Bot 2014-10-15 19:17:37 UTC 
Change 166799 had a related patch set uploaded by SuchetaG:
Replacing push.apply in VE-MW with ve.batchPush from VE core

https://gerrit.wikimedia.org/r/166799
Comment 3 Gerrit Notification Bot 2014-10-15 19:18:21 UTC 
Change 166790 merged by jenkins-bot:
Replacing push.apply with newly created ve.batchPush in VE core

https://gerrit.wikimedia.org/r/166790
Comment 4 James Forrester 2014-10-15 22:13:39 UTC 
VE-MW patch coming or not needed?
Comment 5 Roan Kattouw 2014-10-15 22:17:16 UTC 
(In reply to James Forrester from comment #4)
> VE-MW patch coming or not needed?

There are two usages in VE-MW that do need to be cleaned up. Now that 166790 was pulled through into VE-MW (a few minutes ago) that can be done.
Comment 6 Roan Kattouw 2014-10-15 22:45:03 UTC 
(In reply to Roan Kattouw from comment #5)
> (In reply to James Forrester from comment #4)
> > VE-MW patch coming or not needed?
> 
> There are two usages in VE-MW that do need to be cleaned up. Now that 166790
> was pulled through into VE-MW (a few minutes ago) that can be done.

Ugh somehow we missed the fact that there was a patch for this that was submitted three hours ago. We're both blind :S
Comment 7 Gerrit Notification Bot 2014-10-16 17:44:53 UTC 
Change 166799 merged by jenkins-bot:
Replacing push.apply in VE-MW with ve.batchPush from VE core

https://gerrit.wikimedia.org/r/166799
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links