Last modified: 2014-10-16 12:00:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68192, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 66192 - FundraisingChart should pass jshint
FundraisingChart should pass jshint
Status: REOPENED
Product: MediaWiki extensions
Classification: Unclassified
Other (Other open bugs)
unspecified
All All
: Lowest normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: jshint
  Show dependency tree / graph
 
Reported: 2014-06-05 14:27 UTC by Antoine "hashar" Musso (WMF)
Modified: 2014-10-16 12:00 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Antoine "hashar" Musso (WMF) 2014-06-05 14:27:41 UTC 
jshint reports failure on javascript files and should be fixed. Whenever this is done, one can make the jslint job to be voting by editing integration/zuul-config.git layout.yaml file and remove the line that make the jslint job to be non voting.
Comment 1 Gerrit Notification Bot 2014-06-05 14:39:53 UTC 
Change 137648 had a related patch set uploaded by Hashar:
Ignore  mwext-FundraisingChart-jslint

https://gerrit.wikimedia.org/r/137648
Comment 2 Gerrit Notification Bot 2014-06-05 14:41:24 UTC 
Change 137648 merged by jenkins-bot:
Ignore  mwext-FundraisingChart-jslint

https://gerrit.wikimedia.org/r/137648
Comment 3 Gerrit Notification Bot 2014-07-07 08:37:04 UTC 
Change 144429 had a related patch set uploaded by Hashar:
Default .jshintrc file

https://gerrit.wikimedia.org/r/144429
Comment 4 Gerrit Notification Bot 2014-07-07 08:37:09 UTC 
Change 144430 had a related patch set uploaded by Hashar:
jshint: ignore modules/ext.fundraisingChart.d3

https://gerrit.wikimedia.org/r/144430
Comment 5 Gerrit Notification Bot 2014-07-07 08:37:14 UTC 
Change 144431 had a related patch set uploaded by Hashar:
Pass jshint on resources/js

https://gerrit.wikimedia.org/r/144431
Comment 6 Gerrit Notification Bot 2014-07-07 08:37:18 UTC 
Change 144432 had a related patch set uploaded by Hashar:
Pass jshint on modules/ext.fundraisingChart.datamaps

https://gerrit.wikimedia.org/r/144432
Comment 7 Gerrit Notification Bot 2014-07-07 21:22:00 UTC 
Change 144432 merged by Mwalker:
Pass jshint on modules/ext.fundraisingChart.datamaps

https://gerrit.wikimedia.org/r/144432
Comment 8 Gerrit Notification Bot 2014-07-07 21:22:03 UTC 
Change 144431 merged by Mwalker:
Pass jshint on resources/js

https://gerrit.wikimedia.org/r/144431
Comment 9 Gerrit Notification Bot 2014-07-07 21:22:05 UTC 
Change 144430 merged by Mwalker:
jshint: ignore modules/ext.fundraisingChart.d3

https://gerrit.wikimedia.org/r/144430
Comment 10 Gerrit Notification Bot 2014-07-07 21:22:08 UTC 
Change 144429 merged by Mwalker:
Default .jshintrc file

https://gerrit.wikimedia.org/r/144429
Comment 11 Sam Reed (reedy) 2014-07-24 15:20:39 UTC 
Is this all done now?
Comment 12 Antoine "hashar" Musso (WMF) 2014-07-24 20:20:29 UTC 
Still failing I have a test change at https://gerrit.wikimedia.org/r/#/c/137608/

Yields a failing job https://integration.wikimedia.org/ci/job/mwext-FundraisingChart-jslint/25/console
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links