Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68190, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 66190 - Agora should pass jshint

Summary:	Agora should pass jshint

Status: RESOLVED WONTFIX Product: MediaWiki extensions Classification: Unclassified Component: Other (Other open bugs) Version: unspecified Hardware: All All Importance: Unprioritized normal (vote) Target Milestone: --- Assigned To: Nobody - You can work on this! URL: Whiteboard: Keywords: Depends on: Blocks: jshint   Show dependency tree / graph		Reported: 2014-06-05 14:16 UTC by Antoine "hashar" Musso (WMF) Modified: 2014-09-01 12:16 UTC (History) CC List: 3 users (show) hartman.wiki rmoen spage See Also: Web browser: --- Mobile Platform: --- Assignee Huggle Beta Tester: ---

Attachments Add an attachment (proposed patch, testcase, etc.)

Description Antoine "hashar" Musso (WMF) 2014-06-05 14:16:09 UTC jshint reports failure on javascript files and should be fixed. Whenever this is done, one can make the jslint job to be voting by editing integration/zuul-config.git layout.yaml file and remove the line that make the jslint job to be non voting. Comment 1 Gerrit Notification Bot 2014-06-05 14:39:48 UTC Change 137647 had a related patch set uploaded by Hashar: Ignore mwext-Agora-jslint https://gerrit.wikimedia.org/r/137647 Comment 2 Gerrit Notification Bot 2014-06-05 14:41:11 UTC Change 137647 merged by jenkins-bot: Ignore mwext-Agora-jslint https://gerrit.wikimedia.org/r/137647 Comment 3 Derk-Jan Hartman 2014-09-01 12:16:09 UTC The extension has been discontinued and the JS in it, was negligible anyway. http://git.wikimedia.org/blob/mediawiki%2Fextensions%2FAgora.git/866a03cf3050170587b1f355ad317fd166375b15/modules%2Fjs%2Fext.agora.js