Last modified: 2014-08-05 19:35:22 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68094, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 66094 - Deploy Mantle extension to WMF servers
Deploy Mantle extension to WMF servers
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Extension setup (Other open bugs)
unspecified
All All
: High enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on: 66238
Blocks: 31235 63445 66224
  Show dependency treegraph
 
Reported: 2014-06-03 22:29 UTC by Jon
Modified: 2014-08-05 19:35 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jon 2014-06-03 22:29:35 UTC
Flow and MobileFrontend want to share code that is not quite ready for MediaWiki core (core/mantle - get it?). One big example is sharing of delivering of client side templates via ResourceLoader.

MobileFrontend has been doing this for some time, and the new extension Mantle simply shuffles code from there into a standalone repository so that Flow can use it without being dependent on MobileFrontend.

Sadly this is not quite ready for core - as there has been no standardisation on a default template library.

Once deployed, MobileFrontend can add a hard dependency to Mantle by merging the following patch:
https://gerrit.wikimedia.org/r/#/c/129335/

Read more about Mantle here: https://www.mediawiki.org/wiki/Extension:Mantle

Note: The plan is also to move Nearby functionality into the GeoData extension and add a dependency on GeoData to Mantle.
Comment 1 Greg Grossmeier 2014-06-04 15:15:08 UTC
Any new code here or just a copy/paste operation? I'm only worried because of the word "template" :)
Comment 2 Jon 2014-06-04 22:05:22 UTC
Pretty much a cut and paste job from MobileFrontend with some renaming.

That said there are a few tweaks to the template.js file that allow different template compilers so that as well as Hogan it supports Handlebars.

I suspect if you were to find any issues with Mantle you would also find them with MobileFrontend :)
Comment 3 spage 2014-06-05 23:58:23 UTC
(In reply to Greg Grossmeier from comment #1)
> Any new code here... ?

Yes. Besides the code that was formerly in extension MobileFrontend restructured for code sharing, this introduces the new third-party templating library Handlebars.js in Mantle/javascripts/externals/handlebars.js. That will need security review.
Comment 4 Greg Grossmeier 2014-06-06 04:09:03 UTC
(In reply to spage from comment #3)
> (In reply to Greg Grossmeier from comment #1)
> > Any new code here... ?
> 
> Yes. Besides the code that was formerly in extension MobileFrontend
> restructured for code sharing, this introduces the new third-party
> templating library Handlebars.js in
> Mantle/javascripts/externals/handlebars.js. That will need security review.

Bug 66238
Comment 5 Gerrit Notification Bot 2014-06-25 22:13:55 UTC
Change 142142 had a related patch set uploaded by Spage:
add new Mantle extension, required by coming Flow

https://gerrit.wikimedia.org/r/142142
Comment 6 spage 2014-06-25 23:24:35 UTC
Gerrit change #142142 is for beta labs, https://gerrit.wikimedia.org/r/#/c/142151/ is for production (Gerrit Notification Bot missed the latter?).
Comment 7 Gerrit Notification Bot 2014-06-25 23:55:34 UTC
Change 142142 merged by jenkins-bot:
new Mantle extension on labs, required by coming Flow

https://gerrit.wikimedia.org/r/142142
Comment 8 Tomasz W. Kozlowski 2014-08-05 19:35:22 UTC
This was done ages ago; https://en.wikipedia.org/wiki/Special:Version reports Mantle as deployed.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links