Last modified: 2014-07-23 10:21:54 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68064, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 66064 - ULS: attrName property no longer exposed on jQuery.Event objects in jQuery 1.9


Summary:	ULS: attrName property no longer exposed on jQuery.Event objects in jQuery 1.9

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	UniversalLanguageSelector (Other open bugs)
Version:	master
Hardware:	All All

Importance:	Normal normal (vote)
Target Milestone:	---
Assigned To:	Santhosh Thottingal

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	jqmigrate
	Show dependency tree / graph

Reported:	2014-06-03 08:28 UTC by Adrian Lang
Modified:	2014-07-23 10:21 UTC (History)
CC List:	10 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Adrian Lang 2014-06-03 08:28:22 UTC

jquery.ime uses e.attrName: https://github.com/wikimedia/jquery.ime/blob/f3cf284c5d1f9c0022365dc99eb6811ba39fdb7d/src/jquery.ime.selector.js#L698

That's not available anymore since jQuery 1.9: https://jquery.com/upgrade-guide/1.9/#removed-properties-of-the-event-object

Comment 1 Santhosh Thottingal 2014-06-03 09:01:53 UTC

Thanks for reporting. Upstream fix https://github.com/wikimedia/jquery.ime/commit/dd2aa0f27e554f751abd330d4d66279d838b874b

Comment 2 Krinkle 2014-06-04 20:58:20 UTC

Note:

These are non-standard properties that were not reliably available cross-browser anyway. Even the jQuery.Event object passed as 'event' argument only copied them when available, so that's why it was no longer copied as of jQuery 1.9 because it creates a dangerous API that might work for the developer but not for many users. 

> On any version of jQuery, these properties can still be accessed on browsers that support them by using event.originalEvent instead of event.

Comment 3 Krinkle 2014-06-04 20:58:45 UTC

(In reply to Santhosh Thottingal from comment #1)
> Thanks for reporting. Upstream fix
> https://github.com/wikimedia/jquery.ime/commit/
> dd2aa0f27e554f751abd330d4d66279d838b874b

Cool :) This bug to be closed once it is synced.

Comment 4 Santhosh Thottingal 2014-07-23 10:21:54 UTC

https://gerrit.wikimedia.org/r/#/c/148608/ added the fix to MW ULS. Closing

Note You need to log in before you can comment on or make changes to this bug.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links