Last modified: 2014-07-16 12:27:07 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68030, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 66030 - Review all uses of EntityContent::getEntity()


Summary:	Review all uses of EntityContent::getEntity()

Status:	VERIFIED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	WikidataRepo (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal normal (vote)
Target Milestone:	---
Assigned To:	Wikidata bugs

URL:
Whiteboard:	u=dev c=backend p=8 s=2014-06-17
Keywords:

Depends on:
Blocks:	57744
	Show dependency tree / graph

Reported:	2014-06-02 13:26 UTC by Daniel Kinzler
Modified:	2014-07-16 12:27 UTC (History)
CC List:	5 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Daniel Kinzler 2014-06-02 13:26:36 UTC

Once EntityContent can represent a redirect, EntityContent::getEntity() may fail when called on a redirect. All uses of that method need to be reviewed, removed or guarded against redirects.

Comment 1 Lydia Pintscher 2014-06-03 13:13:45 UTC

expected result:
* simple calls are changed
* separate tickets are filed for complex cases

Comment 2 Gerrit Notification Bot 2014-06-13 15:13:35 UTC

Change 139390 had a related patch set uploaded by Daniel Kinzler:
Check for redirect before calling getEntity().

https://gerrit.wikimedia.org/r/139390

Comment 3 Gerrit Notification Bot 2014-07-01 09:05:50 UTC

Change 139390 merged by jenkins-bot:
Check for redirect before calling getEntity().

https://gerrit.wikimedia.org/r/139390

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links