Last modified: 2014-06-06 07:29:26 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68014, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 66014 - Mantle should pass jshint
Mantle should pass jshint
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Mantle (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: jshint
  Show dependency tree / graph
 
Reported: 2014-06-02 07:19 UTC by Antoine "hashar" Musso (WMF)
Modified: 2014-06-06 07:29 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Antoine "hashar" Musso (WMF) 2014-06-02 07:19:11 UTC 
jshint reports failure on javascript files and should be fixed. Whenever this is done, one can make the jslint job to be voting by editing integration/zuul-config.git layout.yaml file and remove the line that make the jslint job to be non voting.

I already proposed to ignore external dependencies: https://gerrit.wikimedia.org/r/#/c/136715/
Comment 1 Gerrit Notification Bot 2014-06-02 07:20:13 UTC 
Change 136716 had a related patch set uploaded by Hashar:
mwext-Mantle-jslint non voting

https://gerrit.wikimedia.org/r/136716
Comment 2 Gerrit Notification Bot 2014-06-02 07:20:36 UTC 
Change 136716 merged by jenkins-bot:
mwext-Mantle-jslint non voting

https://gerrit.wikimedia.org/r/136716
Comment 3 Antoine "hashar" Musso (WMF) 2014-06-02 07:22:35 UTC 
There is some jshint informations at: https://www.mediawiki.org/wiki/CC/JS#Linting
Comment 4 Gerrit Notification Bot 2014-06-02 07:23:06 UTC 
Change 136715 had a related patch set uploaded by Hashar:
jshint: ignore /javascripts/externals/*

https://gerrit.wikimedia.org/r/136715
Comment 5 Gerrit Notification Bot 2014-06-02 18:07:34 UTC 
Change 136715 merged by jenkins-bot:
jshint: ignore /javascripts/externals/*

https://gerrit.wikimedia.org/r/136715
Comment 6 Jon 2014-06-05 22:54:59 UTC 
Fixed in https://gerrit.wikimedia.org/r/137085
Comment 7 Gerrit Notification Bot 2014-06-06 07:28:18 UTC 
Change 137890 had a related patch set uploaded by Hashar:
mwext-Mantle-jslint is now voting

https://gerrit.wikimedia.org/r/137890
Comment 8 Gerrit Notification Bot 2014-06-06 07:28:41 UTC 
Change 137890 merged by jenkins-bot:
mwext-Mantle-jslint is now voting

https://gerrit.wikimedia.org/r/137890
Comment 9 Antoine "hashar" Musso (WMF) 2014-06-06 07:29:26 UTC 
And Zuul is making the jslint job voting. Thank you!
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links