Last modified: 2014-07-28 08:00:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67954, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 65954 - MobileApp tests are failing
MobileApp tests are failing
Status: RESOLVED FIXED
Product: Wikipedia App
Classification: Unclassified
MobileApp extension (Other open bugs)
Stable
All All
: Normal normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 65874
  Show dependency treegraph
 
Reported: 2014-05-30 17:50 UTC by Kunal Mehta (Legoktm)
Modified: 2014-07-28 08:00 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Kunal Mehta (Legoktm) 2014-05-30 17:50:57 UTC
https://integration.wikimedia.org/ci/job/mwext-MobileApp-testextensions-master/1/console

Looks like it has something to do with a .less validation test?
Comment 1 Antoine "hashar" Musso (WMF) 2014-05-30 21:19:00 UTC
I have added thetestextensions job to several extensions a few days ago. It looks like I forgot to verify MobileApp :-(   I will make the job result to be ignored and move this bug so it get fixed by the extension author.
Comment 2 Gerrit Notification Bot 2014-05-30 21:19:56 UTC
Change 136458 had a related patch set uploaded by Hashar:
Ignore MobileApp unit tests

https://gerrit.wikimedia.org/r/136458
Comment 3 Gerrit Notification Bot 2014-05-30 21:20:22 UTC
Change 136458 merged by jenkins-bot:
Ignore MobileApp unit tests

https://gerrit.wikimedia.org/r/136458
Comment 4 Antoine "hashar" Musso (WMF) 2014-05-30 21:27:36 UTC
The tests are no more voting in Zuul. Whenever the tests are fixed we can make it voting again.  Meanwhile, moving but to MediaWiki extensions component so the bugs get fixed by the extension author.

(Hi Brion!)
Comment 5 Greg Grossmeier 2014-07-19 05:34:38 UTC
(really probably should go under "Wikipedia App" product)
Comment 6 Kunal Mehta (Legoktm) 2014-07-27 22:27:50 UTC
I think this is because the extension depends upon MobileFrontend:

https://integration.wikimedia.org/ci/job/mwext-MobileApp-testextensions-master/68/console

21:28:23 1) /srv/ssd/jenkins-slave/workspace/mwext-MobileApp-testextensions-master/extensions/MobileApp/../MobileFrontend/less/common/reset.less in the "mobile.app.pagestyles.android" module
21:28:23 /srv/ssd/jenkins-slave/workspace/mwext-MobileApp-testextensions-master/extensions/MobileApp/../MobileFrontend/less/common/reset.less in the "mobile.app.pagestyles.android" module must refer to a readable file
21:28:23 Failed asserting that false is true.

And like 8 more.

https://github.com/wikimedia/mediawiki-extensions-MobileApp/blob/master/MobileApp.php#L43
Comment 7 Gerrit Notification Bot 2014-07-27 22:33:19 UTC
Change 149784 had a related patch set uploaded by Legoktm:
MobileApp depends upon MobileFrontend

https://gerrit.wikimedia.org/r/149784
Comment 8 Gerrit Notification Bot 2014-07-28 07:55:58 UTC
Change 149784 merged by jenkins-bot:
MobileApp depends upon MobileFrontend

https://gerrit.wikimedia.org/r/149784
Comment 9 Antoine "hashar" Musso (WMF) 2014-07-28 07:57:26 UTC
The MobileApp Jenkins job was missing dependencies MobileFrontend and Mantle.  A dummy patch ( https://gerrit.wikimedia.org/r/#/c/149803/ ) pass tests now!  Will make it voting and close this bug.

Thank you
Comment 10 Gerrit Notification Bot 2014-07-28 07:58:46 UTC
Change 149804 had a related patch set uploaded by Hashar:
Make MobileApp tests voting

https://gerrit.wikimedia.org/r/149804
Comment 11 Gerrit Notification Bot 2014-07-28 07:59:14 UTC
Change 149804 merged by jenkins-bot:
Make MobileApp tests voting

https://gerrit.wikimedia.org/r/149804
Comment 12 Antoine "hashar" Musso (WMF) 2014-07-28 08:00:31 UTC
Tests are now passing and Zuul is now voting for them. \O/

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links