Last modified: 2014-06-20 21:52:34 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67916, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 65916 - VisualEditor: Media settings dialog shows two selected values of alignment if you unchecking then checking the wrap option
VisualEditor: Media settings dialog shows two selected values of alignment if...
Status: VERIFIED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Normal minor
: VE-deploy-2014-06-12
Assigned To: Moriel Schottlender
:
Depends on:
Blocks: 65829
  Show dependency treegraph
 
Reported: 2014-05-29 21:47 UTC by Rummana Yasmeen
Modified: 2014-06-20 21:52 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot (74.67 KB, image/png)
2014-05-29 21:47 UTC, Rummana Yasmeen
Details

Description Rummana Yasmeen 2014-05-29 21:47:26 UTC
Created attachment 15519 [details]
Screenshot

Steps to reproduce:

1.Insert an image of any type

2.Uncheck the wrap option

3.Check the wrap option again

4.Checking the wrap option automatically selects the "Right" as alignment again

5.Now click on one of the other alignment option:Centre/Left

Observed Result:

The alignment tab for "Right" is still selected, also the new one of step 5
Comment 1 Roan Kattouw 2014-06-04 23:41:06 UTC
Also, if you set the image type to Basic, the alignment checkbox will behave really strangely:

1. Set image type to basic
2. Checkbox is unticked, left/center/right toggle is disabled
3. Click checkbox. Checkbox is ticked and immediately unticked again, but left/center/right toggle is now enabled.
4. Click Left. Checkbox is ticked
5. Untick checkbox. Toggle is now disabled again

Go home alignment widget, you're drunk.
Comment 2 Gerrit Notification Bot 2014-06-05 02:32:22 UTC
Change 137524 had a related patch set uploaded by Mooeypoo:
[wip] Fixing issues in the alignment select in Media Edit dialog

https://gerrit.wikimedia.org/r/137524
Comment 3 Gerrit Notification Bot 2014-06-05 20:46:51 UTC
Change 137729 had a related patch set uploaded by Catrope:
Allow programmatic selection of options while disabled

https://gerrit.wikimedia.org/r/137729
Comment 4 Gerrit Notification Bot 2014-06-06 01:19:49 UTC
Change 137729 merged by jenkins-bot:
Allow programmatic selection of options while disabled

https://gerrit.wikimedia.org/r/137729
Comment 5 Gerrit Notification Bot 2014-06-06 01:32:52 UTC
Change 137524 merged by jenkins-bot:
Fixing issues in the alignment select in Media Edit dialog

https://gerrit.wikimedia.org/r/137524
Comment 6 Gerrit Notification Bot 2014-06-07 00:59:22 UTC
Change 138122 had a related patch set uploaded by Jforrester:
Fixing issues in the alignment select in Media Edit dialog

https://gerrit.wikimedia.org/r/138122
Comment 7 Gerrit Notification Bot 2014-06-07 01:42:26 UTC
Change 138122 merged by jenkins-bot:
Fixing issues in the alignment select in Media Edit dialog

https://gerrit.wikimedia.org/r/138122
Comment 8 Rummana Yasmeen 2014-06-09 21:43:17 UTC
Verified the fix in Betalabs
Comment 9 Rummana Yasmeen 2014-06-13 21:48:34 UTC
Verified the fix in test2 running wmf9
Comment 10 Rummana Yasmeen 2014-06-20 21:52:34 UTC
Verified the fix in production (en.wiki)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links