Last modified: 2014-08-23 18:29:39 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67901, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 65901 - Don't give warning for extra translated units if they're blank
Don't give warning for extra translated units if they're blank
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
Translate (Other open bugs)
master
All All
: Low enhancement (vote)
: ---
Assigned To: Pratik Lahoti
:
Depends on:
Blocks: 65740
  Show dependency treegraph
 
Reported: 2014-05-29 17:08 UTC by Nemo
Modified: 2014-08-23 18:29 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Nemo 2014-05-29 17:08:31 UTC
I had to shift a right hand unit down several units to match the left side and in the end when I saved there were many excess blank units on right hand, so I got the message "Extra units might be present. Please match the source and translation units properly". If they're all empty no harm is done, they should just be ignored.

It's very quick and obvious to delete them though, so this is not important.
Comment 1 Pratik Lahoti 2014-05-31 14:59:44 UTC
The check under question is:

if ( noOfSourceUnits < noOfTranslationUnits ) {

I see two options here:

1. Remove that check itself and Save the messages matched by the user. The logic used is simple - it picks the translation one by one in the order they appear in HTML and saves them. So this would work.

2. Add a function before that check which will decrement the variable noOfTranslationUnits if both source and target text are empty.

Please let me know which one is better.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links