Last modified: 2014-09-13 08:38:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67894, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 65894 - MarkAsHelpful should pass jshint
MarkAsHelpful should pass jshint
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
MarkAsHelpful (Other open bugs)
unspecified
All All
: Lowest normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: jshint
  Show dependency tree / graph
 
Reported: 2014-05-29 15:28 UTC by Antoine "hashar" Musso (WMF)
Modified: 2014-09-13 08:38 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Antoine "hashar" Musso (WMF) 2014-05-29 15:28:56 UTC 
jshint reports failure on javascript files and should be fixed. Whenever this is done, one can make the jslint job to be voting by editing integration/zuul-config.git layout.yaml file and remove the line that make the jslint job to be non voting.

modules/ext.markAsHelpful/ext.markAsHelpful.js: line 144, col 12, 'mediaWiki' is not defined.
Comment 1 Gerrit Notification Bot 2014-05-29 15:30:07 UTC 
Change 136101 had a related patch set uploaded by Hashar:
MarkAsHelpful does not pass jshint (made non voting)

https://gerrit.wikimedia.org/r/136101
Comment 2 Gerrit Notification Bot 2014-05-29 15:30:56 UTC 
Change 136101 merged by jenkins-bot:
MarkAsHelpful does not pass jshint (made non voting)

https://gerrit.wikimedia.org/r/136101
Comment 3 Andre Klapper 2014-07-14 10:10:41 UTC 
[Setting lowest priority as this extension isn't deployed anymore according to bug 67772 comment 1]
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links