Last modified: 2014-06-19 08:40:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67868, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 65868 - Modern and Cologne Blue should remain in Preferences/Appearance after removal from core
Modern and Cologne Blue should remain in Preferences/Appearance after removal...
Product: Wikimedia
Classification: Unclassified
Extension setup (Other open bugs)
All All
: High major (vote)
: ---
Assigned To: Antoine "hashar" Musso (WMF)
: browser-test-bug
Depends on:
Blocks: wmf-deployment
  Show dependency treegraph
Reported: 2014-05-28 18:08 UTC by Chris McMahon
Modified: 2014-06-19 08:40 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

skins gone from Preferences/Appearance (189.46 KB, image/png)
2014-05-28 18:08 UTC, Chris McMahon

Description Chris McMahon 2014-05-28 18:08:26 UTC
Created attachment 15501 [details]
skins gone from Preferences/Appearance

The Modern and Cologne Blue skins have been removed from mediawiki core: and put into the repo at /mediawiki/skins:

However, doing this causes the choices for Modern and Cologne Blue to be removed from Preferences/Appearance.  This was not intended, Modern and Cologne Blue should remain available as preferences. (See screen shot)

10:58 chrismcmahon: hi MatmaRex now that Modern and Cologne Blue skins are no longer in core, do you know if they are supposed to remain available as choices in the Preferences/Appearance settings?
10:59 MatmaRex: chrismcmahon: on Wikimedia wikis? yes, they should
10:59 MatmaRex: chrismcmahon: whoever merged the patches should ensure that the newly created external skins are enabled in WMF environment
10:59 MatmaRex: or whoever wrote the patches
Comment 1 Greg Grossmeier 2014-05-28 19:01:29 UTC
What's the plan here?
Comment 2 Chad H. 2014-05-28 19:05:59 UTC
Comment 3 Bartosz Dziewoński 2014-05-28 23:12:22 UTC
…and also about the deployment. and converted the two skins to use skins/ as their base directory instead of extensions/.
Comment 4 Andre Klapper 2014-05-29 12:57:48 UTC
All three aforementioned patches have been merged.
Comment 5 Krinkle 2014-05-29 13:09:19 UTC
They'll also have to be added to beta labs somehow.
Comment 6 Antoine "hashar" Musso (WMF) 2014-05-29 13:16:37 UTC
Chad did the change that load the Skins  with   that is applied on beta.

Apparently all the skins are registered as submodule of the mediawiki/skins.git repository so we can populate that on beta just like we do with mediawiki/extensions.git
Comment 7 Antoine "hashar" Musso (WMF) 2014-05-29 13:19:23 UTC
Needs to adjust the script which is in puppet so it creates and updates the skins repo.
Comment 8 Greg Grossmeier 2014-05-29 19:32:52 UTC
(In reply to Antoine "hashar" Musso from comment #7)
> Needs to adjust the script which is in puppet so
> it creates and updates the skins repo.

Antoine: due to the passive voice unsure if you are planning on doing this or if you're leaving a hint for Chad ;)
Comment 9 Antoine "hashar" Musso (WMF) 2014-05-29 20:39:26 UTC
If Chad has any interest in hacking in the wmf-beta-autoupdate script I can leave the hacking to him.  I will try to handle that tomorrow afternoon (eu time).
Comment 10 Gerrit Notification Bot 2014-05-30 15:03:00 UTC
Change 136325 had a related patch set uploaded by Hashar:
beta: bring in mediawiki/skins.git
Comment 11 Antoine "hashar" Musso (WMF) 2014-05-30 15:37:49 UTC
I have applied the Gerrit patch above on the beta cluster puppet master.  Then manually triggered the Jenkins job that keeps code in sync ( )  and I can now select Modern and Cologne Blue skins in my MediaWiki preferences.

In production it is not an issue since both skins have been added as git submodules in the deployment branches.
Comment 12 Antoine "hashar" Musso (WMF) 2014-06-02 08:47:32 UTC
Looks like this is fixed.
Comment 13 Gerrit Notification Bot 2014-06-19 08:40:46 UTC
Change 136325 merged by Giuseppe Lavagetto:
beta: bring in mediawiki/skins.git

Note You need to log in before you can comment on or make changes to this bug.