Last modified: 2014-09-11 08:41:19 UTC
We broke switching calendar model it seems. One example is the date of birth in https://www.wikidata.org/wiki/Q1977210. Clicking "change to Julian" in the input expander does nothing.
Seems to be fixed for me with https://github.com/wmde/ValueView/pull/51.
The above patch is live and the issue is still there. It seems to be something else.
Commit pushed to julian at https://github.com/wmde/DataValuesJavascript https://github.com/wmde/DataValuesJavascript/commit/c4fb292c1e7289f18a33561f67999158ad11e04d Fix incomplete Time.equals Bug: 65847
We just tried this and none of the above patches seem to fix it.
Commit pushed to fix-calendar-switch at https://github.com/wmde/ValueView https://github.com/wmde/ValueView/commit/eb2f8eff1fa5a824da0ec4b2ecb102a12b19371d Fix calendar switch to Julian (Bug 65847).
Change 157689 had a related patch set uploaded by Tobias Gritschacher: Use new versions of DataValuesJavascript and ValueView https://gerrit.wikimedia.org/r/157689
Commit pushed to master at https://github.com/wmde/ValueView https://github.com/wmde/ValueView/commit/4695925d785995841f090b95d2f992798c8bffa3 Merge pull request #109 from wmde/fix-calendar-switch Fix calendar switch to Julian (Bug 65847).
The UI is broken. It doesn't convert Julian dates to proleptic Gregorian values. Some time ago it worked fine.
(In reply to JulesWinnfield-hu from comment #8) > The UI is broken. Steps to reproduce welcome.
(In reply to Andre Klapper from comment #9) Enter any date before 1500, try to set Julian calendar model, save, see the stored value. No conversion occures.
(In reply to JulesWinnfield-hu from comment #10) > (In reply to Andre Klapper from comment #9) > Enter any date before 1500, try to set Julian calendar model, save, see the > stored value. No conversion occures. Thanks for your report. I examined the issue and opened a new bug report at bug #70395. If you have additional comments or questions, please add them there. Closing this bug report again since the issue actually realted to this bug report is fixed (will be in the next deployment branch).
(In reply to Henning from comment #11) It's not only about display, though the display is also broken because no conversion occures either. It's about storing wrong date value. This was good at a time. Why had to be changed? Also, dates before 1500 doesn't default to Julian like before.
(In reply to JulesWinnfield-hu from comment #12) > (In reply to Henning from comment #11) > It's not only about display, though the display is also broken because no > conversion occures either. It's about storing wrong date value. > This was good at a time. Why had to be changed? Also, dates before 1500 > doesn't default to Julian like before. Please note that there are several issues. The one described in this bug report has been fixed in https://github.com/wmde/ValueView/pull/109. For another one bug #70395 has been created. You say there is also an issue with storing the wrong data value? We need to investigate that and then open another bug. Or you open one in the meantime. Please do not reopen this bug again as this was only about an issue in the frontend. See the "frontend" tag in the whiteboard.
Opened bug 70398.
Change 157689 merged by jenkins-bot: Use new versions of DataValuesJavascript and ValueView https://gerrit.wikimedia.org/r/157689
