Last modified: 2014-06-09 19:44:33 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67668, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 65668 - SemanticForms: Fix "JQMIGRATE: jQuery.browser is deprecated"
SemanticForms: Fix "JQMIGRATE: jQuery.browser is deprecated"
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
SemanticForms (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: s7eph4n
:
Depends on:
Blocks: jqmigrate-$.browser
  Show dependency treegraph
 
Reported: 2014-05-23 07:58 UTC by Niklas Laxström
Modified: 2014-06-09 19:44 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Niklas Laxström 2014-05-23 07:58:09 UTC
JQMIGRATE: jQuery.browser is deprecated load.php?debug=true&lang=fi&modules=jquery%2Cmediawiki%7Ctwn.jserrorlog&only=scripts&skin=vector&ve…:10350
console.trace() load.php?debug=true&lang=fi&modules=jquery%2Cmediawiki%7Ctwn.jserrorlog&only=scripts&skin=vector&ve…:10352
migrateWarn load.php?debug=true&lang=fi&modules=jquery%2Cmediawiki%7Ctwn.jserrorlog&only=scripts&skin=vector&ve…:10352
Object.defineProperty.get load.php?debug=true&lang=fi&modules=jquery%2Cmediawiki%7Ctwn.jserrorlog&only=scripts&skin=vector&ve…:10367
(anonymous function) jquery.fancybox.js:29
(anonymous function) jquery.fancybox.js:1152

SemanticForms/libs/jquery.fancybox.js
29:             isIE6 = $.browser.msie && $.browser.version < 7 && !window.XMLHttpRequest,
615:                            $('<iframe id="fancybox-frame" name="fancybox-frame' + new Date().getTime() + '" frameborder="0" hspace="0" ' + ($.browser.msie ? 'allowtransparency="true""' : '') + ' scrolling="' + selectedOpts.scrolling + '" src="' + currentOpts.href + '"></iframe>').appendTo(content);
Comment 1 Yaron Koren 2014-05-23 12:36:35 UTC
Re-assigned to Stephan.
Comment 2 Gerrit Notification Bot 2014-06-08 23:15:13 UTC
Change 138287 had a related patch set uploaded by Foxtrott:
fix bug 65668 (jQuery.browser is deprecated)

https://gerrit.wikimedia.org/r/138287
Comment 3 Gerrit Notification Bot 2014-06-08 23:18:59 UTC
Change 138287 merged by Foxtrott:
fix bug 65668 (jQuery.browser is deprecated)

https://gerrit.wikimedia.org/r/138287
Comment 4 s7eph4n 2014-06-08 23:22:03 UTC
Fixed by copying some code from jquery.migrate.js. Wonder how many extensions will do exactly that same thing. :/
Comment 5 Matthew Flaschen 2014-06-09 19:44:33 UTC
As I mentioned at the tracking bug (bug 66097), if you need browser detection (i.e. feature detection isn't enough for the issue you're dealing with), you can use jQuery.client (https://doc.wikimedia.org/mediawiki-core/master/js/#!/api/jQuery.client), which is still supported and in MediaWiki core.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links