Last modified: 2014-07-16 12:00:54 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67594, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 65594 - Create EntityChangeFactory
Create EntityChangeFactory
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Wikidata bugs
u=dev c=backend p=3 s=2014-06-17
:
Depends on:
Blocks: 66029 57744
  Show dependency tree / graph
 
Reported: 2014-05-21 16:53 UTC by Daniel Kinzler
Modified: 2014-07-16 12:00 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Daniel Kinzler 2014-05-21 16:53:54 UTC 
Currently, EntityChange instances are created by EntityChange::newFromUpdate, which uses global state to get en EntityFactory instance. We shoudl avoid this by moving the logic into a dedicated EntityChangeFactory object. This would also move the repo-specific logic out of EntityChange itself.
Comment 1 Gerrit Notification Bot 2014-06-19 14:53:07 UTC 
Change 140709 had a related patch set uploaded by Daniel Kinzler:
Introducing EntityChangeFactory.

https://gerrit.wikimedia.org/r/140709
Comment 2 Gerrit Notification Bot 2014-06-20 20:57:57 UTC 
Change 140709 merged by jenkins-bot:
Introducing EntityChangeFactory.

https://gerrit.wikimedia.org/r/140709
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links