Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67583, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 65583 - Stop using EntityFactory::singleton

Summary:	Stop using EntityFactory::singleton

Status: NEW Product: MediaWiki extensions Classification: Unclassified Component: WikidataRepo (Other open bugs) Version: unspecified Hardware: All All Importance: Normal normal (vote) Target Milestone: --- Assigned To: Wikidata bugs URL: Whiteboard: u=dev c=backend p=0 Keywords: Depends on: Blocks: 65626   Show dependency tree / graph		Reported: 2014-05-21 15:00 UTC by Daniel Kinzler Modified: 2014-11-07 18:12 UTC (History) CC List: 4 users (show) daniel.kinzler jeroen_dedauw lydia.pintscher wikidata-bugs See Also: Web browser: --- Mobile Platform: --- Assignee Huggle Beta Tester: ---

Attachments Add an attachment (proposed patch, testcase, etc.)

Description Daniel Kinzler 2014-05-21 15:00:40 UTC EntityFactory::singleton relies on a hardcoded set of entity types. If we want to support additional types, we need to switch to using WikibaseRepo::getEntityFactory resp. WikibaseClient::getEntityFactory - or, where possible, proper injection of the factory.