Last modified: 2014-06-03 07:26:03 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67570, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 65570 - Flow: title editing exceptions: htmlParseStartTag, and htmlParseEntityRef
Flow: title editing exceptions: htmlParseStartTag, and htmlParseEntityRef
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Nobody - You can work on this!
https://www.mediawiki.org/w/index.php...
:
: 65759 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-05-21 01:21 UTC by Quiddity
Modified: 2014-06-03 07:26 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
screenshot (70.12 KB, image/png)
2014-05-21 01:21 UTC, Quiddity
Details

Description Quiddity 2014-05-21 01:21:26 UTC
Created attachment 15450 [details]
screenshot

Jay8g reports: 

"&" in the topic title gives "The error message received was: Exception Caught: htmlParseEntityRef: no name" and refuse to post.

"<" or "<>" in the topic title (but not ">", "</>" or "<[anything]>", which post) give "The error message received was: Exception Caught: htmlParseStartTag: invalid element name" and refuse to post.

---
See screenshot for confirmation of the first.
Comment 1 spage 2014-05-27 22:07:52 UTC
The PHP exception happens in Parsoid/ReferenceExtractor.php's extractReferences() when it calls createDOM() to record references in the new version of the TopicListBlock. I guess the title content isn't escaped correctly. But Flow should probably not even attempt to record references for title text since nothing in a title is parsed!

To summarize titles in Fl, HTML tags in titles
* Can cause the exception in this bug.
* Incorrectly take effect while previewing (e.g. <em> and <br> cause italics and line breaks).
* Turn into &amp; &lt; &gt; pairs when you edit them (bug 65143).

I think we want a Flow topic title to be an unparsed escaped string, so whatever you enter in it is shown "as is" and has no effect. Limited parsing of titles is an enhancement request.
Comment 2 Quiddity 2014-05-28 20:19:47 UTC
*** Bug 65759 has been marked as a duplicate of this bug. ***
Comment 3 Gerrit Notification Bot 2014-05-30 00:45:49 UTC
Change 136270 had a related patch set uploaded by Bsitu:
Should not try to parse reference from topic title

https://gerrit.wikimedia.org/r/136270
Comment 4 Gerrit Notification Bot 2014-06-02 10:01:06 UTC
Change 136270 merged by jenkins-bot:
Should not try to parse reference from topic title

https://gerrit.wikimedia.org/r/136270

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links