Last modified: 2014-11-19 18:32:52 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67513, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 65513 - VisualEditor: Disentangle MWSaveDialog and mw.ViewPageTarget
VisualEditor: Disentangle MWSaveDialog and mw.ViewPageTarget
Status: ASSIGNED
Product: VisualEditor
Classification: Unclassified
Technical Debt (Other open bugs)
unspecified
All All
: Normal enhancement
: ---
Assigned To: Editing team bugs – take if you're interested!
:
Depends on:
Blocks: 73593
  Show dependency tree / graph
 
Reported: 2014-05-20 00:25 UTC by Roan Kattouw
Modified: 2014-11-19 18:32 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Roan Kattouw 2014-05-20 00:25:54 UTC 
Right now, the way that the save button is disabled when you click it is that MWSaveDialog listens to the button's click event, in response to that it fires the 'save' event, ViewPageTarget gets that event, reaches into the save dialog and disables the button.

This is only one of many insane things about the totally dysfunctional MWSaveDialog - ViewPageTarget relationship; the whole way these two interact should be refactored.
Comment 1 James Forrester 2014-05-20 00:28:22 UTC 
This'd be lovely to get fixed properly. Alex, could you take a look at this at some point? I imagine Roan'd love to be involved in the refactor, though. :-)
Comment 2 James Forrester 2014-06-18 21:36:51 UTC 
Mostly fixed in Gerrit change #135945 but Roan said there are still some outstanding issues.
Comment 3 Alex Monk 2014-06-18 21:43:32 UTC 
Yeah, that patch wasn't really intended to fully fix this.
Comment 4 Gerrit Notification Bot 2014-06-19 23:34:37 UTC 
Change 140868 had a related patch set uploaded by Alex Monk:
Move some stuff from ViewPageTarget to MWSaveDialog

https://gerrit.wikimedia.org/r/140868
Comment 5 Gerrit Notification Bot 2014-11-03 23:30:40 UTC 
Change 140868 abandoned by Alex Monk:
Move some stuff from ViewPageTarget to MWSaveDialog

https://gerrit.wikimedia.org/r/140868
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links