Last modified: 2014-07-31 22:16:48 UTC
<DanielK_WMDE> lazowik: EntityPerPage should provide a function for looking up the ID for a given Title; and/or there should be an inverse of the EntityTitleLookup interface. This is needed e.g. for showing concept and export urls on action=info
What should be implemented? Function in EntityPerPage or new interface? Also EntityPerPage has two related todos: @todo: Combine with the EntityTitleLookup interface? @todo: At least add a way to get page IDs!
It's clear that we should have an getEntityIdForTitle function somewhere, but it's not clear to me where it should reside, and what the exact signature should be (in the future, we may have more than one entity on a page). For now though, I suggest to put that method into the EntityTitleLookup interface, and implemented it in EntityContentFactory (which implements EntityTitleLookup) like this: $id = $idParser->parser( $title->getText() ) This isn't 100% future proof, but will work for now. This should make it easy enough to change the logic later.
Change 134727 had a related patch set uploaded by Michał Łazowik: Add getting entity id from page title https://gerrit.wikimedia.org/r/134727
Change 134727 abandoned by Michał Łazowik: Introduce EntityIdLookup Reason: Need to figure out a good place for that and do a bit of refactoring beforehand. https://gerrit.wikimedia.org/r/134727
