Last modified: 2014-08-29 01:58:16 UTC
On https://en.wikipedia.org/wiki/Main_Page?uselang=en&useskin=vector the links from sections "Interaction", "Tools", "Print/Export" and "Languages" are not aligned with the Links from the top ("Navigation") section. Maybe this was caused by the removal of the collapsible feature?
The current formatting also makes many items to wrap to a new line.
(In reply to Helder from comment #1) > The current formatting also makes many items to wrap to a new line. Ignore this comment, I was testing something on Firefox and set the minimum font size to 13px. This was the cause of the wrapping...
Why is this a code-update-regression, and what is the actual problem? I guess they are not meant to be aligned, because these section were collapsible a while ago, but I don't see any change in indentation compared to the last weeks?
Compare the bugzilla sidebar to the sidebar on the wikis. On bugzilla, there is no indentation for the uncollapsed sections. This is how it should look like on the wikis as well. Also, see the image on https://www.mediawiki.org/wiki/Wikimedia_Foundation_Design/Whitespace#Alignment Before the code update, there was a image in the left of the headers, and in that case the margin(padding?) makes sense, to make the items aligned with the header. Now, there is no icon, so there should be no white space either.
Change-Id: I220057c799bef7e8c4d964f47d56f61ec120d8c2
Created attachment 15437 [details] en.wiki sidebar without JavaScript The screenshots on that page are useless, because they show everything collapsed (even stuff which normally isn't). The misalignment is caused by the JavaScript which removes the header "navigation" in the first sidebar box, see for instance in 1.18: http://wiki.wikimedia.it/wiki/Pagina_principale?useskin=vector Misaligning the sidebar was probably the intended effect, so this is not really a bug; no idea what enhancements would be accepted.
/skins/vector/components/navigation.less assign different margin values to div#mw-panel div.portal div.body and div#mw-panel div.portal.first div.body The former uses the default @menu-main-body-margin (0 0 0 1.25em; } while the latter uses { margin-left: .5em } hence the .75em difference in indentation. Caused by https://gerrit.wikimedia.org/r/#/c/131402/
I tried to improve the bug summary.
Change 134311 had a related patch set uploaded by Odder: Fix indentation in Vector sidebar links https://gerrit.wikimedia.org/r/134311
(In reply to Helder from comment #2) > (In reply to Helder from comment #1) > > The current formatting also makes many items to wrap to a new line. > Ignore this comment, I was testing something on Firefox and set the minimum > font size to 13px. This was the cause of the wrapping... Indeed. They were already aligned like this. The position is exactly the same as before we removed the collapsibleNav module.
(In reply to Helder from comment #4) > Compare the bugzilla sidebar to the sidebar on the wikis. On bugzilla, there > is no indentation for the uncollapsed sections. This is how it should look > like on the wikis as well. > > Also, see the image on > https://www.mediawiki.org/wiki/Wikimedia_Foundation_Design/ > Whitespace#Alignment > > Before the code update, there was a image in the left of the headers, and in > that case the margin(padding?) makes sense, to make the items aligned with > the header. Now, there is no icon, so there should be no white space either. Note that the Bugzilla sidebar has another important difference. It has the separator lines between the header and the items. Not between the sections. Bugzilla (and how Vector was in 2009): Header -------- Item Item Header -------- Item Item MediaWiki Vector (2010-2013) \/ Header Item Item -------- \/ Header Item Item MediaWiki Vector (now) Header Item Item -------- Header Item Item
(In reply to Krinkle from comment #11) To be more explicit: MediaWiki Vector (now) Item Item -------- Header Item Item -------- Header Item Item
(In reply to Helder from comment #12) > (In reply to Krinkle from comment #11) > > To be more explicit Indeed, the first section has no heading and is not indented. However, that also has been the case since 2010. I think we need design input (which I can provide, but I'd like a second pair of eyes on this) because this is not a technical matter. My argument is: * Aligning header and items is fine (e.g. no extra indentation), but in that case we should move the separator line back to between the header and the items (like it was in 2009, and how it still is on Bugzilla). Otherwise it gets too crammy and too close to each other. * The current proposed patch set (I0c880c1a31dae6c patch set 2) would in my opinion be a regression as it doesn't align the items, nor does it keep separation. What it does is remove the indentation but keeps the margins as they are which means they now neither have spacial separation, nor a line separation, and don't have alignment either. They almost have any of them, but exactlt have nothing. That patch changes it to: ---- Heading Item Item The space here in front of "Item" is exaggerated, it basically makes it almost match but not exactly (see http://i.imgur.com/AmmLMjc.png), and removes a lot of the visual separation, breathing room and decluttering.
(In reply to Krinkle from comment #13) > * Aligning header and items is fine (e.g. no extra indentation), but in that > case we should move the separator line back to between the header and the > items (like it was in 2009, and how it still is on Bugzilla). Otherwise it > gets too crammy and too close to each other. Makes sense. > The space here in front of "Item" is exaggerated, it basically makes it > almost match but not exactly (see http://i.imgur.com/AmmLMjc.png), and > removes a lot of the visual separation, breathing room and decluttering. Agreed, that screenshot is no good.
Created attachment 15476 [details] What it used to be Since I have access to an instance with a somewhat older version of vector, a screeshot of how it once was.
That can be achieved by undoing parts of https://gerrit.wikimedia.org/r/#/c/131402/. There will likely still be parts of that change that should remain, and some parts that were changed/removed at other times that may need restoring.
Change 134311 abandoned by Odder: Fix indentation in Vector sidebar links https://gerrit.wikimedia.org/r/134311
