Last modified: 2014-05-19 10:53:54 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67405, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 65405 - "process the upload" backend code should have flags "do not overwrite" and "overwrite only" to avoid race condition
"process the upload" backend code should have flags "do not overwrite" and "o...
Status: NEW
Product: MediaWiki
Classification: Unclassified
Uploading (Other open bugs)
1.24rc
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 65338
  Show dependency treegraph
 
Reported: 2014-05-16 17:12 UTC by Rainer Rillke @commons.wikimedia
Modified: 2014-05-19 10:53 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Rainer Rillke @commons.wikimedia 2014-05-16 17:12:27 UTC
In Bug 65338, it turned out (and was proven) that the API allows overwriting files despite ignorewarnings is not set in race conditions:

Brad Jorsch:
> There's a race condition in the uploading code: it first checks for warnings 
> and then processes the upload, and what's happening here is that one of your 
> parallel requests is sneaking in an upload between the "check for warnings" 
> and "process the upload" steps.

And it is suggested to have some flags in the backend preventing that:
> If the "process the upload" backend code were to have flags to say "do not 
> overwrite" and "overwrite only", we could use that from the API code to fix 
> this race condition.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links