Last modified: 2014-05-27 10:14:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67400, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 65400 - ULS: Fix "JQMIGRATE: $(html) HTML strings must start with '<' character" in jquery.uls.core.js
ULS: Fix "JQMIGRATE: $(html) HTML strings must start with '<' character" in j...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UniversalLanguageSelector (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Santhosh Thottingal
: easy
Depends on:
Blocks: jqmigrate
  Show dependency treegraph
 
Reported: 2014-05-16 15:36 UTC by Krinkle
Modified: 2014-05-27 10:14 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Krinkle 2014-05-16 15:36:18 UTC
JQMIGRATE: $(html) HTML strings must start with '<' character 
- jquery.uls.core.js :88
https://github.com/wikimedia/mediawiki-extensions-UniversalLanguageSelector/blob/fb41b2/lib/jquery.uls/src/jquery.uls.core.js#L88

> this.$menu = $( template );


If it contains text (e.g. "Hello world"), then you have to use $.fn.html() or $.parseHTML instead due to ambiguity with a css selector.

If it contains leading whitespace or '#', then $() no longer allows this for consistency and security reasons, and also, use $.parseHTML(), or fix the string to not have leading whitespace.


I think in case of ULS you just need to make sure that leading new line is gone.
Comment 1 Santhosh Thottingal 2014-05-18 04:54:28 UTC
Fixed in upstream commit
https://github.com/wikimedia/jquery.uls/commit/9599ed7d267585b3dedf53fc6c53d35b11cfa5a6

Leading space/newline characters were removed from template strings.
Comment 2 Gerrit Notification Bot 2014-05-22 04:27:27 UTC
Change 134622 had a related patch set uploaded by Santhosh:
Update jquery.uls to afb99eb0

https://gerrit.wikimedia.org/r/134622
Comment 3 Gerrit Notification Bot 2014-05-22 11:23:32 UTC
Change 134622 merged by jenkins-bot:
Update jquery.uls to 36478fa55a0

https://gerrit.wikimedia.org/r/134622

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links