Last modified: 2014-08-22 00:42:40 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67343, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 65343 - VisualEditor: Link inspector ignores selected value
VisualEditor: Link inspector ignores selected value
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: High major
: VE-deploy-2014-06-12
Assigned To: Trevor Parscal
:
: 68934 (view as bug list)
Depends on:
Blocks: ve-linkediting
  Show dependency treegraph
 
Reported: 2014-05-15 12:01 UTC by Krinkle
Modified: 2014-08-22 00:42 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Krinkle 2014-05-15 12:01:56 UTC
1. Edit some text (e.g the -> foo)
1. Edit existing link (e.g. on [[mw:VisualEditor]], link to "Parsoid")
2. Enter text that makes up part of a title (e.g. "ResourceLoade", note, the missing "r" at the end)
3. Select "ResourceLoader" from the suggestions
   (due to a bug in our search engine, this is the second suggestion, not the first:
   [ > ResourceLoade                                 ]
     - ResourceLoader/JavaScript Deprecations
     - ResourceLoader
     - ResourceLoader/Version 1 Design Specification

4. Observe that the suggestions close after selecting an item, and the text field now contains "ResourceLoader". Do not press enter or click anywhere.

5. Press Save Page

Video: http://cl.ly/11431q402d3A

Expected:

* Diff shows "the -> foo", and "Parsoid -> ResourceLoader".


Actual:

* Diff shows "the -> foo".

Because:

We both selected a value from the suggestions and then blurred the inspector by clicking "Save page". Either of those actions ought to save the value into the model, but doing both certainly should.

There are two weird things about this:

* Changing step 4 and pressing Enter there instead of Save page, makes it save correctly.

So it seems that we just don't save properly on selection or blurring and require one of Escape-key, Enter-key, Back-button or focussing surface (instead of blurring inspector / focussing anything in the main window, e.g. toolbar / save button as well, not just surface).

* Changing step 2/3 to type "ResourceLoader" straight up, and not pressing Enter or clicking anywhere before clicking Save page also works. 

So it seems that merely changing focus from input field to save page can be enough to have it saved. Maybe we have an exception for onkeyup/onchange and select is bypassing that?
Comment 1 Gerrit Notification Bot 2014-06-12 00:37:40 UTC
Change 138114 had a related patch set uploaded by Catrope:
[BREAKING CHANGE] Update VE core submodule to master (43a48cb) for window process cleanup

https://gerrit.wikimedia.org/r/138114
Comment 2 Gerrit Notification Bot 2014-06-12 00:44:10 UTC
Change 138114 merged by jenkins-bot:
[BREAKING CHANGE] Update VE core submodule to master (43a48cb) for window process cleanup

https://gerrit.wikimedia.org/r/138114
Comment 3 Krinkle 2014-06-25 16:19:04 UTC
Following the steps exactly as per comment #0 still exhibits this bug exactly.

I can reproduce it locally on latest master by making a link to User:Root when typing "User:Ro" where the suggestions are [ "User:Root/common.js", "User:Root" ].
Comment 4 Roan Kattouw 2014-08-22 00:06:47 UTC
*** Bug 68934 has been marked as a duplicate of this bug. ***
Comment 5 Gerrit Notification Bot 2014-08-22 00:09:55 UTC
Change 155673 had a related patch set uploaded by Catrope:
Select the correct annotation in MWLinkTargetInputWidget

https://gerrit.wikimedia.org/r/155673
Comment 6 Gerrit Notification Bot 2014-08-22 00:15:34 UTC
Change 155673 merged by jenkins-bot:
Select the correct annotation in MWLinkTargetInputWidget

https://gerrit.wikimedia.org/r/155673
Comment 7 James Forrester 2014-08-22 00:42:23 UTC
*** Bug 68934 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links