Last modified: 2014-09-01 03:43:57 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67166, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 65166 - VisualEditor: If you open the image inspector, and the image doesn't have a type specified (like thumb), then you can't get out again
VisualEditor: If you open the image inspector, and the image doesn't have a ...
Status: NEW
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Editing team bugs – take if you're interested!
:
Depends on:
Blocks: ve-mediasupport
  Show dependency tree / graph
 
Reported: 2014-05-10 22:05 UTC by WhatamIdoing
Modified: 2014-09-01 03:43 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description WhatamIdoing 2014-05-10 22:05:58 UTC 
Steps to Reproduce:
1. Create a page that contains at least one image with no thumb or similar file specification, e.g., 

[[File:Example.jpg|Here's an image.]]

2. Open the page in VisualEditor.  

3. Select the image and open the image inspector.

4. Try to get out of the image inspector.

Actual Results:  
The "Advanced settings" pane in the image inspector has a spinning death spiral and the error message, "Size values are invalid. Could not retrieve original file size." 

The X to close the image inspector does not respond.


Reproducible: Always

This was first reported by Magioladitis for the pdf's listed here:  https://el.wikipedia.org/w/index.php?oldid=4650532#.CE.94.CE.B9.CE.B1.CE.BB.CE.AD.CE.BE.CE.B5.CE.B9.CF.82
Comment 1 Moriel Schottlender 2014-05-12 17:02:18 UTC 
This image is rendered as an inline image and the dialog, at the moment, won't edit it at all. The editing capability for inline images is introduced in the upcoming (big) change for the Image Model.

I've tried to reproduce the bug in both local master and in betalabs and the image doesn't let me open the edit dialog (as expected)

See here: http://en.wikipedia.beta.wmflabs.org/wiki/2014_May_11_TestImageBug?veaction=edit

Am I missing something?
Comment 2 Liangent 2014-05-12 17:08:13 UTC 
(In reply to Moriel Schottlender from comment #1)
> This image is rendered as an inline image and the dialog, at the moment,
> won't edit it at all. The editing capability for inline images is introduced
> in the upcoming (big) change for the Image Model.
> 
> I've tried to reproduce the bug in both local master and in betalabs and the
> image doesn't let me open the edit dialog (as expected)
> 
> See here:
> http://en.wikipedia.beta.wmflabs.org/wiki/
> 2014_May_11_TestImageBug?veaction=edit
> 
> Am I missing something?

Double clicking the image opens the "Media settings" dialog for me.
Comment 3 Moriel Schottlender 2014-05-12 17:11:59 UTC 
Okay I just realized a huge bug: The image dialog popup/button doesn't appear (because it shouldn't yet) but double-clicking opens the media edit dialog.

And since the image is inline, the dialog is not ready to handle it, the dialog then crashes.

This seems to be a double-click bug; WhatamIdoing can you approve that this is how you opened the dialog?
Comment 4 WhatamIdoing 2014-05-12 18:18:50 UTC 
Not exactly:  I selected it and pressed the Return key.  It has the same effect.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links