Last modified: 2014-10-23 19:44:50 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67077, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 65077 - VisualEditor: IME detection should not use useragent sniffing


Summary:	VisualEditor: IME detection should not use useragent sniffing

Status:	RESOLVED FIXED

Product:	VisualEditor
Classification:	Unclassified
Component:	Language (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	High normal
Target Milestone:	VE-deploy-2014-06-26
Assigned To:	D Chan

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-05-09 15:30 UTC by Ed Sanders
Modified:	2014-10-23 19:44 UTC (History)
CC List:	8 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Ed Sanders 2014-05-09 15:30:51 UTC

in ve.ce.Surface we the following line:

 if ( $.browser.msie === true && e.which === 229 ) {

Give we haven't tested IE in so longer I suspect this might not work anymore, but if it does, we need another way to detect that this hack is needed as $.browser is deprecated.

Comment 1 D Chan 2014-05-19 15:21:56 UTC

I'm in the process of stripping these checks out anyway, because the inIme checks cannot be made realiable. Does this need removing immediately? If so I can submit a smaller patch that does this.

Comment 2 Krinkle 2014-05-19 15:23:17 UTC

It needs to not use $.browser within 2 weeks tops.

Comment 3 James Forrester 2014-05-29 16:15:59 UTC

Bumping priority as this needs to be done very soon…

Comment 4 Krinkle 2014-05-29 16:19:01 UTC

Rephrasing to be the bug David wants to work on in general.

For the literal usage of $.browser, see bug 65404.

Comment 5 D Chan 2014-10-23 10:10:00 UTC

Was fixed by https://gerrit.wikimedia.org/r/#/c/141457 .

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links