Last modified: 2014-05-24 21:05:22 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67018, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 65018 - Move MoodBar user preference to "Appearance" tab
Move MoodBar user preference to "Appearance" tab
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
MoodBar (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: PiRSquared17
: easy
Depends on:
Blocks: redesign-sp-prefs
  Show dependency treegraph
 
Reported: 2014-05-07 20:18 UTC by Quiddity
Modified: 2014-05-24 21:05 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Quiddity 2014-05-07 20:18:07 UTC
TL;DR: Per bug 52757 and bug 52759

Currently, [[mw:Extension:MoodBar]] adds a user preference under the "Misc" tab:

[ ] Disable Moodbar

This user preference should either be removed entirely (allowing users to hide the UI with a JavaScript gadget or custom CSS) or moved to the "Appearance" user preferences tab (as the other extensions have done).
Comment 1 p858snake 2014-05-07 20:22:13 UTC
(In reply to Quiddity from comment #0)
> This user preference should either be removed entirely (allowing users to
> hide the UI with a JavaScript gadget or custom CSS) 

No, Having a proper user preference is better here. Telling users to disable extensions via js and css mods is a crappy thing to do.
Comment 2 Nemo 2014-05-07 20:25:24 UTC
This is a very invasive extension, it's probably best to leave the preference. I'm not sure how it relates to "appearance" though.
Comment 3 Quiddity 2014-05-07 20:31:02 UTC
Sorry, ignore the bit about "removed entirely" (I was copying the text from bug 52757).

(In reply to Nemo from comment #2)
> This is a very invasive extension, it's probably best to leave the
> preference. I'm not sure how it relates to "appearance" though.

A) Because it changes the widgets visible on every page. 
B) Because there's nowhere else for it to go!  :)

Note: It's only in current use on 5 wikis: [[mw:MoodBar#Status]]
Comment 4 MZMcBride 2014-05-08 03:30:59 UTC
Death to the "Misc" tab!

This request seems fine, marking it with the "easy" keyword accordingly (this is a trivial one-line change, I imagine). Quiddity: careful with the copying and pasting. ;-)

Tangentially, it may make sense to file a bug about searching all MediaWiki extensions in Git for other references to the "Misc" user preference tab.
Comment 5 Andre Klapper 2014-05-08 09:43:29 UTC
Note: It's only "easy" if it's non-controversial.
Comment 6 Gerrit Notification Bot 2014-05-24 05:04:07 UTC
Change 135179 had a related patch set uploaded by Gerrit Patch Uploader:
Move MoodBar preference to "Appearance" tab

https://gerrit.wikimedia.org/r/135179
Comment 7 Gerrit Notification Bot 2014-05-24 21:03:56 UTC
Change 135179 merged by jenkins-bot:
Move MoodBar preference to "Appearance" tab

https://gerrit.wikimedia.org/r/135179

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links