Last modified: 2014-05-09 02:06:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T66975, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 64975 - Show and hide gadgets depending on skin compatibility
Show and hide gadgets depending on skin compatibility
Status: RESOLVED WORKSFORME
Product: MediaWiki extensions
Classification: Unclassified
Gadgets (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy
Depends on:
Blocks: redesign-sp-prefs
  Show dependency treegraph
 
Reported: 2014-05-06 22:28 UTC by Jared Zimmerman (WMF)
Modified: 2014-05-09 02:06 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
non-vector compatible gadgets showing when vector is enabled (91.29 KB, image/png)
2014-05-07 20:27 UTC, Jared Zimmerman (WMF)
Details

Description Jared Zimmerman (WMF) 2014-05-06 22:28:07 UTC
Many gadgets are skin specific, it might be cleaner if only gadgets that were compatible with the current skin showed at any given time.
Comment 1 Jared Zimmerman (WMF) 2014-05-06 22:29:20 UTC
I'm referring to visibility in https://en.wikipedia.org/wiki/Special:Preferences#mw-prefsection-gadgets
Comment 2 Helder 2014-05-07 18:36:40 UTC
For a real example:
https://en.wikipedia.org/wiki/MediaWiki:Gadgets-definition#appearance
has
* VectorClassic[ResourceLoader|skins=vector]|VectorClassic.css
and
and the option "Vector classic typography (use only sans-serif in Vector skin)" should not appear on
https://en.wikipedia.org/wiki/Special:Preferences?useskin=monobook#mw-prefsection-gadgets
Comment 3 Bartosz Dziewoński 2014-05-07 19:02:49 UTC
This is already supported, save for the bug Helder pointed out (which already has a bug report).

*** This bug has been marked as a duplicate of bug 63532 ***
Comment 4 Helder 2014-05-07 19:07:12 UTC
Hm.. I was pretty sure this was supported, then I tested with the url above and it didn't work, so I just posted the example... I completely forgot that I reported the problem with the useskin parameter.
Comment 5 Jared Zimmerman (WMF) 2014-05-07 20:27:02 UTC
Created attachment 15316 [details]
non-vector compatible gadgets showing when vector is enabled
Comment 6 Jared Zimmerman (WMF) 2014-05-07 20:28:15 UTC
Isn't the bug you marked this as a dupe of, only for when your using different skins via a url switch, rather than when its enabled as your normal skin?
Comment 7 Bartosz Dziewoński 2014-05-07 20:29:17 UTC
I do not have the ability to edit English Wikipedia's gadgets definition to make these actually depend on the skin. We do not support natural language processing…
Comment 8 Bartosz Dziewoński 2014-05-07 20:29:55 UTC
(In reply to Jared Zimmerman (WMF) from comment #6)
> Isn't the bug you marked this as a dupe of, only for when your using
> different skins via a url switch, rather than when its enabled as your
> normal skin?

Yes. When it is enabled as a normal skin, this works, as long as the dependency is specified in the gadgets definition. I supposed it could be RESOLVED WORKSFORME instead.
Comment 9 Jared Zimmerman (WMF) 2014-05-07 20:30:45 UTC
Do gadgets not have a value or flag in them to say what skin they are compatible with?
Comment 10 Jared Zimmerman (WMF) 2014-05-07 20:31:43 UTC
Bartosz, you can see from my screenshot is does not work. I have vector enabled as a normal skin (not a url switch) and I'm seeing monobook only gadgets
Comment 11 Bartosz Dziewoński 2014-05-07 20:33:22 UTC
(In reply to Jared Zimmerman (WMF) from comment #9)
> Do gadgets not have a value or flag in them to say what skin they are
> compatible with?

They have, 'skins='. However, the ones on the English Wikipedia do not have this flag set correctly (other than one which is set to depend on Vector), see [[en:MediaWiki:Gadgets-definition]]. Local administrators can fix this, I can not.
Comment 12 Helder 2014-05-07 20:37:52 UTC
[conflict]

(In reply to Jared Zimmerman (WMF) from comment #9)
> Do gadgets not have a value or flag in them to say what skin they are
> compatible with?

According to 
https://en.wikipedia.org/wiki/MediaWiki:Gadgets-definition?oldid=606473655
there is only one gadget currently using the "skins=" parameter: VectorClassic.

The other gadgets in your screenshot need to be marked similarly, or they will show up and be loaded in every skin.
Comment 13 Jared Zimmerman (WMF) 2014-05-07 20:47:36 UTC
Ok so from what I've heard we don't log bugzilla tickets against individual gadgets, but I'm reopening this bug as a pseudo tracking bug while there are gadgets that don't have "skins=" parameter correctly set.
Comment 14 Bartosz Dziewoński 2014-05-07 23:01:45 UTC
We don't use Bugzilla for tracking on-wiki issues. None of us discussing this here have the permissions necessary to fix the gadgets (unless you use your staff powers for this). Please raise this issue on the Village Pump on Wikipedia.
Comment 15 MZMcBride 2014-05-08 03:27:04 UTC
(In reply to Bartosz Dziewoński from comment #14)
> We don't use Bugzilla for tracking on-wiki issues.

This actually isn't true in many cases. :-)  (For example, we encourage small wikis to report site issues in Bugzilla where they'll get attention rather than on desolate and obscure local MediaWiki namespace talk pages.)

But in this particular case, making an on-wiki request is probably the best course of action given the vibrant technical community on the English Wikipedia.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links