Last modified: 2006-06-29 23:28:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T8490, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 6490 - Clean up rendering code in ImageGallery.php


Summary:	Clean up rendering code in ImageGallery.php

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	File management (Other open bugs)
Version:	1.7.x
Hardware:	All All

Importance:	Normal enhancement (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:	patch, patch-need-review

Depends on:
Blocks:	6491
	Show dependency tree / graph

Reported:	2006-06-29 18:49 UTC by Ilmari Karonen
Modified:	2006-06-29 23:28 UTC (History)
CC List:	0 users

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Patch to clean up image gallery rendering code (3.27 KB, patch) 2006-06-29 18:52 UTC, Ilmari Karonen	Details
Patch to clean up image gallery rendering code (fixed) (3.26 KB, patch) 2006-06-29 19:56 UTC, Ilmari Karonen	Details
Patch to clean up image gallery rendering code (minor tweak) (11.18 KB, patch) 2006-06-29 22:14 UTC, Ilmari Karonen	Details
Patch to clean up image gallery rendering code (fixed after tweak) (3.31 KB, patch) 2006-06-29 22:28 UTC, Ilmari Karonen	Details
Show Obsolete (3) Add an attachment (proposed patch, testcase, etc.)

Description Ilmari Karonen 2006-06-29 18:49:58 UTC

I'm splitting this patch out of patch 1762 (bug 5985, "Allow images in the bad
image list to be used on specific pages"), as these changes have nothing to with
the bad image list whatsoever.

Comment 1 Ilmari Karonen 2006-06-29 18:52:45 UTC

Created attachment 2022 [details]
Patch to clean up image gallery rendering code

This patch cleans up ImageGallery::toHTML(), factoring the HTML generation out
of the various error and corner cases.

Comment 2 Ilmari Karonen 2006-06-29 19:56:31 UTC

Created attachment 2023 [details]
Patch to clean up image gallery rendering code (fixed)

Oops, didn't split the patch cleanly last time, the check for mParsing was
wrong.	Should be fixed now.

Comment 3 Ilmari Karonen 2006-06-29 22:14:28 UTC

Created attachment 2027 [details]
Patch to clean up image gallery rendering code (minor tweak)

Yet another version, this one wraps the error message given if thumbnailing
fails into a div, hopefully making it look better.  (Can't really test that,
since I don't know how to generate such an error.)

Comment 4 Ilmari Karonen 2006-06-29 22:28:19 UTC

Created attachment 2028 [details]
Patch to clean up image gallery rendering code (fixed after tweak)

That last patch had a bunch of unrelated crap included.  This one's what I
meant to upload.

Comment 5 Brion Vibber 2006-06-29 23:28:28 UTC

Applied on r15164

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links