Last modified: 2014-06-20 21:01:34 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T66859, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 64859 - Reenable content model support for Syntaxhighlight
Reenable content model support for Syntaxhighlight
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
SyntaxHighlight (GeSHi) (Other open bugs)
master
All All
: Normal normal (vote)
: MW 1.24 version
Assigned To: Bartosz Dziewoński
:
Depends on:
Blocks: 27397
  Show dependency tree / graph
 
Reported: 2014-05-05 00:26 UTC by Derk-Jan Hartman
Modified: 2014-06-20 21:01 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Derk-Jan Hartman 2014-05-05 00:26:26 UTC 
This https://gerrit.wikimedia.org/r/#/c/52268/ was never re-enabled.
Comment 1 Derk-Jan Hartman 2014-05-05 01:01:36 UTC 
Because of this, in https://gerrit.wikimedia.org/r/#/c/126843 we patched the wrong function. Also when fixing the right function, it seems the fix doesn't work....

:(
Comment 2 Bartosz Dziewoński 2014-05-05 09:49:38 UTC 
Maybe related: bug 27397?

We should probably explicitly drop compatibility with older MWs on SyntaxHighlight master already.
Comment 3 Bartosz Dziewoński 2014-05-05 10:34:20 UTC 
Plot twist: core support for this was reverted in https://gerrit.wikimedia.org/r/#/c/67860/. The code implementing this in SyntaxHighlight is thus entirely and wholly dead.
Comment 4 Bartosz Dziewoński 2014-05-05 10:55:24 UTC 
There is a revert of the revert pending at https://gerrit.wikimedia.org/r/#/c/67983/.
Comment 5 Gerrit Notification Bot 2014-05-05 11:05:53 UTC 
Change 131447 had a related patch set uploaded by Bartosz Dziewoński:
[DOES NOT WORK] Use ContentGetParserOutput hook instead of ShowRawCssJs

https://gerrit.wikimedia.org/r/131447
Comment 6 Gerrit Notification Bot 2014-05-05 17:15:23 UTC 
Change 131502 had a related patch set uploaded by Bartosz Dziewoński:
Article: Add entire ParserOutput in showCssOrJsPage() like in view()

https://gerrit.wikimedia.org/r/131502
Comment 7 Bartosz Dziewoński 2014-05-05 17:18:33 UTC 
(In reply to Gerrit Notification Bot from comment #5)
> [DOES NOT WORK] Use ContentGetParserOutput hook instead of ShowRawCssJs

Does work now with the core patch above (and all of its dependencies).
Comment 8 Gerrit Notification Bot 2014-06-20 19:59:20 UTC 
Change 131502 merged by jenkins-bot:
Article: Add RL modules for the ParserOutput when showing CSS/JS page

https://gerrit.wikimedia.org/r/131502
Comment 9 Gerrit Notification Bot 2014-06-20 20:00:23 UTC 
Change 131447 merged by jenkins-bot:
Use ContentGetParserOutput hook instead of ShowRawCssJs

https://gerrit.wikimedia.org/r/131447
Comment 10 Bartosz Dziewoński 2014-06-20 21:01:34 UTC 
Hooray, this will work again!
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links