Last modified: 2014-09-05 02:57:15 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T66734, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 64734 - mw-ui-vform's label styling makes the login form hard to read on dark skins
mw-ui-vform's label styling makes the login form hard to read on dark skins
Status: NEW
Product: MediaWiki
Classification: Unclassified
MediaWiki UI (Other open bugs)
1.24rc
All All
: Lowest enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 64731
  Show dependency treegraph
 
Reported: 2014-05-02 02:01 UTC by Daniel Friesen
Modified: 2014-09-05 02:57 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Daniel Friesen 2014-05-02 02:01:07 UTC
`.mw-ui-vform > div label` specifies an explicit dark color. On dark skins this means the contrast becomes low and in the worst case (the skin isn't using an absolute black) becomes illegible.

This case isn't fixed by simply applying an explicit color somewhere so we'll probably have to create a new 'dark' common/skinning module.
Comment 1 Jared Zimmerman (WMF) 2014-08-28 22:52:13 UTC
Updating the importance since this does not affect default skin.
Comment 2 Matthew Flaschen 2014-09-04 21:18:14 UTC
(In reply to Daniel Friesen from comment #0)
> This case isn't fixed by simply applying an explicit color somewhere so
> we'll probably have to create a new 'dark' common/skinning module.

Why can't the dark skin(s) specify an explicit color in a skinStyles style sheet for mediawiki.ui (or the relevant module)?  I am inclined to resolve as invalid and request that individual skins fix this.

However, if the dark label only looks right in a limited number of skins, the alternative is to put skinStyles for those skins (not convinced of that so far) (e.g. Vector, Monobook, etc.).

Unless I'm mistaken, creating a new module would change the API for how MW UI is used.  Using skinStyles/$wgResourceModuleSkinStyles would not have this issue.

I don't agree with Jon's new title.  All dark skins do not look alike.  Why should MW UI look alike in all of them?

Also, improving every aspect of MW UI in every dark skin would greatly expand the scope of this bug.  Let's stick the original report.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links