Last modified: 2014-05-01 15:54:06 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T66564, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 64564 - mediawiki.util should be more modular
mediawiki.util should be more modular
Status: NEW
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
1.24rc
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: code_quality
  Show dependency tree / graph
 
Reported: 2014-04-28 19:07 UTC by Jon
Modified: 2014-05-01 15:54 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Jon 2014-04-28 19:07:33 UTC 
mediawiki.util has a function
updateTooltipAccessKeys and addPortletLink

The minerva skin has no concept of portlets
The dependency jquery.accessKeyLabel is thus unnecessary

I'd suggest separating this functionality out into:
mediawiki.util.portlets
which extends the mediawiki util object to have this functionality.
Comment 1 Derk-Jan Hartman 2014-04-29 21:34:35 UTC 
Actually, it should probably be more of an api, that is implemented in the various skins JS, to reliably add 'navigation entries' to 'navigation blocks'.
Comment 2 Bartosz Dziewoński 2014-04-29 22:04:29 UTC 
Yeah, that should be part of a hypothetical 'mediawiki.currentSkin' module (which skins would somehow extend).
Comment 3 Jon 2014-04-29 22:12:04 UTC 
Yes!!!! This sounds like a good approach!! :)
Comment 4 Helder 2014-04-29 22:28:18 UTC 
Possibly related to bug 23515.
Comment 5 Krinkle 2014-05-01 15:29:11 UTC 
See also (bug 26799) Restrict mediawiki.util to general JavaScript utilities only.

This should probably be moved to a mw.Skin module. However, regardless of what Minerva will and will not support, this module must always implement addPortletLink. The implementation can change dynamically based on skin (it would be exposed through one canonical interface), but the programmatic interface must be reliable for gadgets.

Minerva's implementation would replace the function with a no-op, and not have a dependency on accessKeyLabel.
Comment 6 Jon 2014-05-01 15:54:06 UTC 
Sounds good.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links