Last modified: 2014-04-27 14:00:45 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T66504, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 64504 - Notification involving suppressed revision produces erroneous link
Notification involving suppressed revision produces erroneous link
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
Echo (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-04-27 13:59 UTC by Scott Martin (http://enwp.org/user:scott)
Modified: 2014-04-27 14:00 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Scott Martin (http://enwp.org/user:scott) 2014-04-27 13:59:43 UTC
If you get a notification involving a revision which was suppressed before you saw it, you get this message:

Example mentioned you on the Example talk page in "This page revision has been suppressed.".

Links in the above are

<Example> → User:Example
<Example talk page> → Talk:Example
<This page revision has been suppressed.> → Talk:Example#This_page_revision_has_been_suppressed.

The suppression message is getting treated as a section ID, trailing full stop and all, which is obviously incorrect.

There doesn't seem to be much point in delivering such a notification, but by the looks of it that would be complicated. Echo appears to be pulling the page title at the time the user asks to see the notification, by which point it's gone. Perhaps Special:RevisionDelete could pass suppressed revision IDs to Echo at the time of action, saying "cancel any unsent notifications relating to this revision"? Seems like it might take some work to do though.

Failing that, I'd suggest a correction of:

Example mentioned you on the Example talk page, but that revision has been suppressed.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links