Last modified: 2014-11-15 06:45:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T66457, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 64457 - refactor sitelinks structure to support badges
refactor sitelinks structure to support badges
Product: Pywikibot
Classification: Unclassified
Wikidata (Other open bugs)
All All
: High major
: ---
Assigned To: Ricordisamoa
Depends on: 40810
Blocks: pwb20
  Show dependency treegraph
Reported: 2014-04-25 21:59 UTC by Ricordisamoa
Modified: 2014-11-15 06:45 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description Ricordisamoa 2014-04-25 21:59:54 UTC
When badges will be actually supported by the WikibaseRepo extension (bug 40810, [[d:Wikidata:Development_plan#Badges]]), we may have to rework the whole structure of ItemPage.sitelinks, either:
* using tuples as (Page, (ItemPage, ItemPage, ))
* creating a new Sitelink class, with ItemPage.iterlinks() iterating over a list of Sitelink instances, returning a Page object, and Sitelink.badges containing a list of ItemPage instances;
The latter scheme would probably increase maintainability in the long term.

Of course, we will also add functions to edit badges via the API.
Comment 1 Ricordisamoa 2014-04-30 22:33:54 UTC
Even better: the Sitelink class should inherit from Page and then set the .badges property.
Comment 2 Gerrit Notification Bot 2014-05-02 04:41:24 UTC
Change 131019 had a related patch set uploaded by Ricordisamoa:
[POC] [BREAKING] refactor the sitelinks structure
Comment 3 Ricordisamoa 2014-09-02 03:47:15 UTC
Badges are now used on the 'production' Wikidata!

Note You need to log in before you can comment on or make changes to this bug.