Last modified: 2010-05-15 15:28:19 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T2644, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 644 - text on the same line as a comment breaks comment parsing
text on the same line as a comment breaks comment parsing
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
1.3.x
PC Windows XP
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
http://pl.wikipedia.org/w/wiki.phtml?...
: need-parsertest
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2004-10-05 00:49 UTC by lɛʁi לערי ריינהארט
Modified: 2010-05-15 15:28 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description lɛʁi לערי ריינהארט 2004-10-05 00:49:03 UTC
Dear friends,

Please take a look at http://pl.wikipedia.org/w/wiki.phtml?
title=Rasy_ps%C3%B3w&action=history and see two versions:

(bież) (poprz)  23:47, 4 paź 2004 217.233.94.166 (Gangleri) 
(bież) (poprz)  23:45, 4 paź 2004 217.233.94.166 (Gangleri 
de:Hunderasse -> de:Liste der Hunderassen) 

The difference between them is only a "carriage return":
The older one contains:
<!--- no category here so far --->[[de:Liste der Hunderassen]]
The newer one contains:
<!--- no category here so far --->  
[[de:Liste der Hunderassen]]

I was surprised, that the older version shows only one language 
at "in other languages"  and the newer seven.

Regards Reinhardt
Comment 1 Rowan Collins [IMSoP] 2004-11-08 20:34:07 UTC
The problem appears to be that the other links were sandwiched between two
comments, and the text on the same line as the first confused the parser into
ignoring everything until after the second. A simplified test-case is:

Intro
<!--a comment-->deadly text
invisible text
<!--another comment-->
Outro

or even:

Intro
<!--a comment-->deadly text
invisible text
stray markup-->
Outro

In both cases, the page renders as "Intro Outro", the parser seemingly pairing
the 1st "<!--" with the 2nd "-->"; note that without the second comment there at
all, everything appears as you would expect. However, I notice that this appears
to have been fixed in CVS, in that the test server doesn't show the same
problem: http://test.wikipedia.org/wiki/Comments displays as it should. So
presumably, this will be fixed when 1.4 goes stable, but whether it's severe
enough that the necessary change should be tracked down and backported, I'll
leave to someone else to decide.
Comment 2 Brion Vibber 2004-12-11 23:25:34 UTC
1.4 release imminent, resolving as fixed.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links