Last modified: 2014-07-16 10:32:54 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T66309, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 64309 - ChangeOps should have a separate function for validation.
ChangeOps should have a separate function for validation.
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Wikidata bugs
u=dev c=backend p=5 s=2014-05-06
:
Depends on:
Blocks: 62643
  Show dependency treegraph
 
Reported: 2014-04-23 19:11 UTC by Daniel Kinzler
Modified: 2014-07-16 10:32 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Daniel Kinzler 2014-04-23 19:11:43 UTC
ChangeOps should perform validation against a target entity separately from the apply() method, in validate() method.

The rationale is:

1) when applying a batch of ChangeOps, we want to be able to validate all before applying any.

2) for some batch operations like merging, we don't want to apply validation, since we are dealing with "status quo" data, and we shouldn't fail if that status quo does not conform to soft constraints (hard constraints should and will of course still be enforced).
Comment 1 Gerrit Notification Bot 2014-04-23 19:35:14 UTC
Change 129244 had a related patch set uploaded by Daniel Kinzler:
(bug 64309) Introducing ChangeOp::validate

https://gerrit.wikimedia.org/r/129244
Comment 2 JulesWinnfield-hu 2014-05-20 22:36:16 UTC
Does this resolve bug 65215?
Comment 3 JulesWinnfield-hu 2014-05-21 10:20:20 UTC
Could you take a look at bug 65215?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links