Last modified: 2014-06-16 04:44:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T66224, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 64224 - Fatal error: Access level to PagedTiffHandler::visibleMetadataFields() must be public
Fatal error: Access level to PagedTiffHandler::visibleMetadataFields() must b...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
PagedTiffHandler (Other open bugs)
REL1_23-branch
All Linux
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-04-22 07:32 UTC by dan
Modified: 2014-06-16 04:44 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description dan 2014-04-22 07:32:18 UTC 
error message
-------------
Fatal error: Access level to PagedTiffHandler::visibleMetadataFields() must be public (as in class MediaHandler) in /var/www/w/extensions/PagedTiffHandler/PagedTiffHandler_body.php on line 780

steps to reproduce
------------------
1. install PagedTiffHandler (68ce9fe).
2. ImageMagick is available.
3. exiv2 is available.
4. libvips31 is available.
5. previous tiffs were uploaded without thumbnails being created.
6. navigate to Special:RecentChanges

potential solution
------------------
this worked for the wiki i was working on. modify the method, visibleMetadataFields, on line 603 of PagedTiffHandler_body.php so that it’s marked as public.
Comment 1 Gerrit Notification Bot 2014-04-22 07:34:59 UTC 
Change 127876 had a related patch set uploaded by Dan-nl:
mark method visibleMetadataFields as public

https://gerrit.wikimedia.org/r/127876
Comment 2 Gerrit Notification Bot 2014-04-22 09:33:49 UTC 
Change 127876 merged by jenkins-bot:
mark method visibleMetadataFields as public

https://gerrit.wikimedia.org/r/127876
Comment 3 Gerrit Notification Bot 2014-04-22 09:34:39 UTC 
Change 127887 had a related patch set uploaded by Reedy:
mark method visibleMetadataFields as public

https://gerrit.wikimedia.org/r/127887
Comment 4 Andre Klapper 2014-05-16 12:28:47 UTC 
Patch merged in git master; remaining open patch in comment 3 is for 1.23 branch
Comment 5 Gerrit Notification Bot 2014-05-24 19:58:32 UTC 
Change 127887 merged by jenkins-bot:
mark method visibleMetadataFields as public

https://gerrit.wikimedia.org/r/127887
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links