Last modified: 2014-06-06 15:38:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T66115, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 64115 - Tool Labs: Provide filtered view of user_properties table containing short list of properties, linked to userID
Tool Labs: Provide filtered view of user_properties table containing short li...
Status: RESOLVED FIXED
Product: Wikimedia Labs
Classification: Unclassified
tools (Other open bugs)
unspecified
All All
: High normal
: ---
Assigned To: Marc A. Pelletier
: easy
Depends on:
Blocks: tool-missing-ts-feat
  Show dependency treegraph
 
Reported: 2014-04-18 22:42 UTC by Luis Villa (WMF Legal)
Modified: 2014-06-06 15:38 UTC (History)
15 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Luis Villa (WMF Legal) 2014-04-18 22:42:31 UTC
+++ This bug was initially created as a clone of Bug #58196 +++

Key comments (edited to make them make sense with each other):

Comment 15 Liangent 2014-03-14 06:35:23 UTC

...

Those are two different requests: one table (view) containing user identifiable info (user id) with fewer properties includes, and another anonymized one with more properties.

Comment 16 Luis Villa (WMF Legal) 2014-03-14 18:57:06 UTC

Retitling then :) 

For the filtered table: I am OK with this in principle, but would like to better understand (1) how we choose which fields to filter and (2) how we prevent new fields from leaking.

For the anonymized table: Again, OK in principle; it would be good (but not a must-have) to know more about the impact on users of small wikis.

Description Kunal Mehta (Legoktm) 2013-12-09 05:17:15 UTC 

...

Only preferences that are considered to be public are replicated, the list from enwiki_p is:
mysql> select distinct(up_property) from user_properties;
+----------------+
| up_property    |
+----------------+
| disablemail    |
| fancysig       |
| gender         |
| language       |
| nickname       |
| skin           |
| timecorrection |
| variant        |
+----------------+

Comment 23 Krinkle 2014-03-27 20:17:11 UTC

...

The Toolserver's non-anonimized filtered view has a much stricter whitelist:

nlwiki_p at toolserver> SELECT DISTINCT(up_property) FROM user_properties;
+----------------+
| up_property    |
+----------------+
| disablemail    |
| fancysig       |
| gender         |
| language       |
| nickname       |
| skin           |
| timecorrection |
| variant        |
+----------------+
8 rows in set

-------------

Based on the discussion in the other bug: legal approves creation of a view on Labs of the user_properties table, where the eight properties listed above are exposed with userid, property, and value.

This should, if at all possible, be whitelist-based, so that new properties are not accidentally exposed. If we need to add more properties, please discuss with legal at that time.

If anyone here thinks I've misunderstood something about this table, please speak now :)
Comment 1 JuneHyeon Bae (devunt) 2014-06-01 23:36:28 UTC
Since toolserver shutdown, all tools should be migrated to Tool Labs before June 30th 2014. Changing importance.
Comment 2 Marc A. Pelletier 2014-06-04 13:45:08 UTC
Handing off to Sean for the underlying table.
Comment 3 Sean Pringle 2014-06-05 10:13:07 UTC
Table is replicated.
Comment 4 Gerrit Notification Bot 2014-06-06 15:06:22 UTC
Change 137938 had a related patch set uploaded by coren:
Labs: new replication views

https://gerrit.wikimedia.org/r/137938
Comment 5 Gerrit Notification Bot 2014-06-06 15:36:49 UTC
Change 137938 merged by coren:
Labs: new replication views

https://gerrit.wikimedia.org/r/137938

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links