Last modified: 2014-10-28 23:35:45 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T66101, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 64101 - Lots of background images not using data URI embedding
Lots of background images not using data URI embedding
Status: PATCH_TO_REVIEW
Product: MobileFrontend
Classification: Unclassified
Feature requests (Other open bugs)
unspecified
All All
: Low normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on: 71181
Blocks:
  Show dependency treegraph
 
Reported: 2014-04-18 19:58 UTC by Roan Kattouw
Modified: 2014-10-28 23:35 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Roan Kattouw 2014-04-18 19:58:37 UTC
When I installed MobileFrontend without exposing /w/extensions/MobileFrontend on my web server, I got 8 404s for various images and lots of stuff was missing from the interface.

Grepping showed that there are lots and lots of background images that aren't embedded because they're not using the mixin.

Example of correct code:

less/common/ui.less
53:	#mw-mf-main-menu-button {
54-		.background-size( 24px, auto );
55-		background-position: 40% 40%;
56-		.background-image-svg( 'images/menu/hamburger.svg', 'images/menu/hamburger.png' );
57-	}

Example of incorrect code:

less/common/pageactions.less
81-#ca-edit {
82:	background-image: url(images/pagemenu/edit-locked.png);
--
84-	&.enabled {
85:		background-image: url(images/pagemenu/edit.png);

I forget what the mixin is for when you don't have both an SVG and a PNG (also, isn't there an SVG for every single icon?), but there is one in MW core and it should be used.

Running ack-grep -Q 'url(' -B 1 extensions/MobileFrontend/less reveals a total of 50 (!!) cases where url() is used without /* @embed */ and without using a mixin.
Comment 1 Bingle 2014-04-18 20:00:08 UTC
Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1941
Comment 2 Ori Livneh 2014-04-18 20:26:02 UTC
Mobile folks: since you're going to be looking at this in the context of MobileFrontend, I'd really appreciate it if you also grepped for this pattern across all deployed extensions and helped triage or fix any additional occurrences.
Comment 3 Gerrit Notification Bot 2014-10-02 18:51:30 UTC
Change 161321 had a related patch set uploaded by Jdlrobson:
WIP: Use mw-ui-icon

https://gerrit.wikimedia.org/r/161321
Comment 4 Gerrit Notification Bot 2014-10-06 20:46:34 UTC
Change 165096 had a related patch set uploaded by Jdlrobson:
WIP: Use mw-ui-icon in beta

https://gerrit.wikimedia.org/r/165096
Comment 5 Gerrit Notification Bot 2014-10-06 20:47:00 UTC
Change 161321 abandoned by Jdlrobson:
WIP: Use mw-ui-icon in beta

Reason:
https://gerrit.wikimedia.org/r/165096

https://gerrit.wikimedia.org/r/161321
Comment 6 Gerrit Notification Bot 2014-10-22 19:04:23 UTC
Change 168138 had a related patch set uploaded by Jdlrobson:
Use mw-ui-icon in alpha

https://gerrit.wikimedia.org/r/168138
Comment 7 Gerrit Notification Bot 2014-10-27 19:59:12 UTC
Change 168138 merged by jenkins-bot:
Use mw-ui-icon in alpha

https://gerrit.wikimedia.org/r/168138

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links