Last modified: 2014-05-09 19:51:45 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T66065, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 64065 - Hovercards throws error on Special:MyLanguage links
Hovercards throws error on Special:MyLanguage links
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Popups (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Prateek Saxena
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-04-17 16:35 UTC by Jean-Fred
Modified: 2014-05-09 19:51 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jean-Fred 2014-04-17 16:35:08 UTC
Hovercards throws a JavaScript error when hovering on a link using Special:MyLanguage

Steps to reproduce:
*Go to <https://commons.wikimedia.org/wiki/Commons:Upload_tools>
*Hover on any link (eg Upload Wizard)
*Error is thrown in notif:

Error: https://bits.wikimedia.org/commons.wikimedia.org/load.php?debug=false&lang=fr&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.triggerQueueCallback%2CloadingSpinner%2CmwEmbedUtil%7Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20140417T030828Z at line 0: Script error.

This may be the case with all Special: pages (as on the same page, Special:Preferences fails too), but as a user I expect Hovercards to work on MyLanguage pages, since they are topical pages.
Comment 1 Prateek Saxena 2014-04-18 14:10:17 UTC
Thanks for pointing this out Jean!

The error occurs when the extension tries to obtain a timestamp for the special page (which does not exist).

> Uncaught TypeError: Cannot read property '0' of undefined
> at line 69 of ext.popups.core.js
Comment 2 Gerrit Notification Bot 2014-04-22 09:45:44 UTC
Change 127889 had a related patch set uploaded by Prtksxna:
Check if revisions exist before getting a timestamp

https://gerrit.wikimedia.org/r/127889
Comment 3 Prateek Saxena 2014-04-22 10:32:49 UTC
Max, does TextExtracts return anything for Special pages anyway?
Comment 4 Gerrit Notification Bot 2014-04-28 11:08:53 UTC
Change 127889 abandoned by Prtksxna:
Check if revisions exist before getting a timestamp

Reason:
Rebase hell.

https://gerrit.wikimedia.org/r/127889
Comment 5 Gerrit Notification Bot 2014-04-28 11:30:09 UTC
Change 130058 had a related patch set uploaded by Prtksxna:
Don't show popups if the page does not have the `.extract` property

https://gerrit.wikimedia.org/r/130058
Comment 6 Gerrit Notification Bot 2014-05-01 05:17:06 UTC
Change 130058 abandoned by Prtksxna:
Don't show popups if the page does not have the `.extract` property

Reason:
Part of the restructure

https://gerrit.wikimedia.org/r/130058

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links