Last modified: 2014-07-22 10:31:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T66060, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 64060 - GWToolset silently wraps some fields into MediaWiki templates, which is problematic
GWToolset silently wraps some fields into MediaWiki templates, which is probl...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
GWToolset (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: dan
:
: 64851 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-04-17 15:08 UTC by Jean-Fred
Modified: 2014-07-22 10:31 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
test metadataset (2.77 KB, text/xml)
2014-05-15 15:09 UTC, dan
Details
test metadata mapping (710 bytes, application/json)
2014-05-15 15:09 UTC, dan
Details

Description Jean-Fred 2014-04-17 15:08:34 UTC
The GWToolset silently wraps the content of Institution field in {{Institution:}} and artist in {{Creator:}}.

This is problematic because:

1/ It does not say so, which is surprising for the user who might not expect to see red templates on the results page (as said templates will probably not exist).

2/ It is sometimes uncalled for. Artist might be values not appropriate for Creator templates like "Unknown", or a local craftsman.

Not sure what the best way forward is. At the very least this should be documented on the interface (I can submit a patch for that).
Tickbox to wrap the field (or to not wrap it for that matter)?
Comment 1 Jean-Fred 2014-05-09 13:43:10 UTC
*** Bug 64851 has been marked as a duplicate of this bug. ***
Comment 2 Gerrit Notification Bot 2014-05-13 01:05:52 UTC
Change 133041 had a related patch set uploaded by Dan-nl:
Make template wrapping optional.

https://gerrit.wikimedia.org/r/133041
Comment 3 Gerrit Notification Bot 2014-05-15 10:37:36 UTC
Change 133041 abandoned by Dan-nl:
Make template wrapping optional

Reason:
having a problem merging https://gerrit.wikimedia.org/r/#/c/133041/ and 
https://gerrit.wikimedia.org/r/#/c/133293/. the two are related so will put them into one patch instead.

https://gerrit.wikimedia.org/r/133041
Comment 4 dan 2014-05-15 15:09:10 UTC
Created attachment 15397 [details]
test metadataset
Comment 5 dan 2014-05-15 15:09:40 UTC
Created attachment 15398 [details]
test metadata mapping
Comment 6 johanmmuller 2014-05-22 14:40:35 UTC
This is an important bug: it is still impossible to use a simple author-field (without template). Hansmuller
Comment 8 dan 2014-06-26 07:31:58 UTC
the patch has been deployed to production. are you okay with closing this bug now?
Comment 9 Jean-Fred 2014-07-22 10:31:20 UTC
Yes, the GWToolset now gives the option to not wrap. Closing as fixed.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links